Skip to content

Commit 1057a81

Browse files
auroranockertwpolicarpo
authored andcommitted
Fix constants missing in 6.0.0.rc1
1 parent 2dc497b commit 1057a81

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

lib/arel/visitors/sqlserver.rb

+9-9
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def visit_Arel_Nodes_UpdateStatement(o, a)
3131

3232
def visit_Arel_Nodes_Lock o, collector
3333
o.expr = Arel.sql('WITH(UPDLOCK)') if o.expr.to_s =~ /FOR UPDATE/
34-
collector << SPACE
34+
collector << " "
3535
visit o.expr, collector
3636
end
3737

@@ -57,7 +57,7 @@ def visit_Arel_Nodes_SelectStatement o, collector
5757
distinct_One_As_One_Is_So_Not_Fetch o
5858
if o.with
5959
collector = visit o.with, collector
60-
collector << SPACE
60+
collector << " "
6161
end
6262
collector = o.cores.inject(collector) { |c,x|
6363
visit_Arel_Nodes_SelectCore(x, c)
@@ -95,7 +95,7 @@ def visit_Arel_Nodes_JoinSource o, collector
9595
collector = visit_Arel_Nodes_SelectStatement_SQLServer_Lock collector
9696
end
9797
if o.right.any?
98-
collector << SPACE if o.left
98+
collector << " " if o.left
9999
collector = inject_join o.right, collector, ' '
100100
end
101101
collector
@@ -106,7 +106,7 @@ def visit_Arel_Nodes_InnerJoin o, collector
106106
collector = visit o.left, collector
107107
collector = visit_Arel_Nodes_SelectStatement_SQLServer_Lock collector, space: true
108108
if o.right
109-
collector << SPACE
109+
collector << " "
110110
visit(o.right, collector)
111111
else
112112
collector
@@ -117,7 +117,7 @@ def visit_Arel_Nodes_OuterJoin o, collector
117117
collector << "LEFT OUTER JOIN "
118118
collector = visit o.left, collector
119119
collector = visit_Arel_Nodes_SelectStatement_SQLServer_Lock collector, space: true
120-
collector << SPACE
120+
collector << " "
121121
visit o.right, collector
122122
end
123123

@@ -126,20 +126,20 @@ def visit_Arel_Nodes_OuterJoin o, collector
126126
def visit_Arel_Nodes_SelectStatement_SQLServer_Lock collector, options = {}
127127
if select_statement_lock?
128128
collector = visit @select_statement.lock, collector
129-
collector << SPACE if options[:space]
129+
collector << " " if options[:space]
130130
end
131131
collector
132132
end
133133

134134
def visit_Orders_And_Let_Fetch_Happen o, collector
135135
make_Fetch_Possible_And_Deterministic o
136136
unless o.orders.empty?
137-
collector << SPACE
138-
collector << ORDER_BY
137+
collector << " "
138+
collector << " ORDER BY "
139139
len = o.orders.length - 1
140140
o.orders.each_with_index { |x, i|
141141
collector = visit(x, collector)
142-
collector << COMMA unless len == i
142+
collector << ", " unless len == i
143143
}
144144
end
145145
collector

0 commit comments

Comments
 (0)