Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Test against stable tags for narwhals #18191

Open
vyasr opened this issue Mar 6, 2025 · 0 comments
Open

[FEA] Test against stable tags for narwhals #18191

vyasr opened this issue Mar 6, 2025 · 0 comments
Assignees
Labels
feature request New feature or request

Comments

@vyasr
Copy link
Contributor

vyasr commented Mar 6, 2025

Is your feature request related to a problem? Please describe.
We now have CI jobs that clone the test suites from narwhals. This is very helpful to use for maintaining coverage of the relevant APIs. We would like to eventually move to a model where we can require that these tests pass consistently, but at the moment these are not required CI jobs due to potential instability from upstream changes.

Describe the solution you'd like
For pandas tests, we check out a stable branch of the code prior to running tests. That branch is controlled by the pandas version that we install into the testing environment, which in turn is managed by dependencies.yaml. To improve the stability of our narwhals tests, instead of cloning the latest of any branch (even their stable branch) we should follow the same pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants