Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Run pylibcudf test with optional dependencies uninstalled #18201

Open
mroeschke opened this issue Mar 7, 2025 · 0 comments
Open

[FEA] Run pylibcudf test with optional dependencies uninstalled #18201

mroeschke opened this issue Mar 7, 2025 · 0 comments
Labels
feature request New feature or request

Comments

@mroeschke
Copy link
Contributor

Is your feature request related to a problem? Please describe.
#18020 added a pylibcudf.Scalar.from_numpy API to interact with numpy scalars. Since we want pylibcudf to have minimal dependencies, the API was designed to assume numpy was an option dependency and may possibly not be installed. Currently we don't test scenario this since we run pylibcudf tests with cudf tests which the latter requires numpy.

Describe the solution you'd like
We should ideally have a step which tests pylibcudf without numpy (or any optional dependency xref #17046) installed. Possibly in the same job we can uninstall numpy or create a new virtual env in the same job without pylibcudf optional dependencies.

Describe alternatives you've considered
A whole separate job that just test pylibcudf without optional dependencies (probably unnecessary to have a dedicated job for this just to isolate environments)

Additional context
Add any other context, code examples, or references to existing implementations about the feature request here.

@mroeschke mroeschke added the feature request New feature or request label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant