WIP: type-erase offsets buffer type in contiguous_split #18232
+70
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large strings have an int64 offset buffer, so we must handle that.
wence-
added
bug
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
wence-
commented
Mar 11, 2025
| @@ -160,7 +181,7 @@ __device__ void copy_buffer(uint8_t* __restrict__ dst, | |||
| std::size_t element_size, | |||
| std::size_t src_element_index, | |||
| uint32_t stride, | |||
| int value_shift, | |||
| cuda::std::int64_t value_shift, | |||
There was a problem hiding this comment.
@nvdbaranec points out this copy_buffer implementation needs to be templated on this the type of the offsets buffer (lines 201-215 in this PR) for example, so that we load and modify the values appropriately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Large strings have an int64 offset buffer, so we must handle that.
Checklist