Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dataframe.loc to not modify the actual dataframe #18254

Open
wants to merge 3 commits into
base: branch-25.04
Choose a base branch
from
Open

Fix Dataframe.loc to not modify the actual dataframe #18254

wants to merge 3 commits into from

Conversation

galipremsagar
Copy link
Contributor

Description

Fixes: #18242

This PR fixes two issues in DataFrame.loc:

  1. Inplace modification of the original dataframe.
  2. Returning series instead of dataframe for a specific combination of loc inputs.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 12, 2025
@galipremsagar galipremsagar self-assigned this Mar 12, 2025
@galipremsagar galipremsagar requested a review from a team as a code owner March 12, 2025 19:41
@github-actions github-actions bot added the Python Affects Python cuDF API. label Mar 12, 2025
@galipremsagar galipremsagar added bug Something isn't working and removed bug Something isn't working improvement Improvement / enhancement to an existing function labels Mar 12, 2025
@galipremsagar galipremsagar requested a review from mroeschke March 12, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@Matt711 Matt711 Awaiting requested review from Matt711 Matt711 is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Selection of rows by label renders dataframe invalid
2 participants
@galipremsagar @mroeschke