Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden TOC appears with long header titles #4007

Open
dev-jonghoonpark opened this issue Mar 7, 2025 · 5 comments
Open

Hidden TOC appears with long header titles #4007

dev-jonghoonpark opened this issue Mar 7, 2025 · 5 comments
Labels
help wanted We need contributions on this type/documentation A documentation update

Comments

@dev-jonghoonpark
Copy link
Contributor

dev-jonghoonpark commented Mar 7, 2025

The Table of Contents (TOC), which is hidden under the LEFT PANEL, appears when the header has a long title.

You can check in https://projectreactor.io/docs/core/release/reference/metrics.html

Image

When the screen width is less than 1024px, the LEFT PANEL disappears, making the TOC more visible.

Image

If the screen width is less than or equal to 800px, the TOC disappears completely, and there is no issue in this case.


Why is the hidden TOC necessary?

@dev-jonghoonpark dev-jonghoonpark added the type/documentation A documentation update label Mar 7, 2025
@chemicL
Copy link
Member

chemicL commented Mar 10, 2025

Hey, thank you for a detailed report! I don't think it's necessary, it must be a bug. Do you have an idea where the issue lies? If so, a contribution would be very much welcome.

cc @violetagg - I believe the reactor-netty antora docs have the same issue.

@chemicL chemicL added the help wanted We need contributions on this label Mar 10, 2025
@dev-jonghoonpark
Copy link
Contributor Author

dev-jonghoonpark commented Mar 10, 2025

I realized that in Antora, there are two TOCs: one inside the content and one outside.

this is one inside (for mobile)
Image

this is one outside (for desktop)
Image

In Antora documentation, the TOC inside the content is completely hidden using display: none for desktop size.
On the other hand, in the reactor documentation, the TOC inside the content is hidden inside the left panel using position: absolute.

How about simply hiding the TOC inside the content with display: none in the reactor documentation as well?

It seems that to achieve this, a PR would need to be submitted to
https://github.com/reactor/antora-ui-projectreactor.

@violetagg
Copy link
Member

At some point we fixed that reactor/reactor-netty#3177
Let me check again Reactor Netty documentation

@violetagg
Copy link
Member

violetagg commented Mar 10, 2025

@chemicL @dev-jonghoonpark mmm yeah ignore my previous comment, it seems the PR that I mentioned fixes another thing, but the issue described here is present with Reactor Netty documentation also

@dev-jonghoonpark
Copy link
Contributor Author

dev-jonghoonpark commented Mar 11, 2025

Image

Additionally, I discovered that the button on the top right exists but serves no functional purpose.

While resolving this issue, it would be good to hide this button as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted We need contributions on this type/documentation A documentation update
Projects
None yet
Development

No branches or pull requests

3 participants