From 709b5ee19cf96ed851d31da07315ea38d7fafdc8 Mon Sep 17 00:00:00 2001 From: Jayme Howard Date: Mon, 17 May 2021 11:48:43 -0500 Subject: [PATCH 1/2] Convert experiment not found log to a warning --- reddit_experiments/__init__.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/reddit_experiments/__init__.py b/reddit_experiments/__init__.py index 2c536c8..0aa2c6c 100644 --- a/reddit_experiments/__init__.py +++ b/reddit_experiments/__init__.py @@ -1,5 +1,6 @@ import json import logging +import warnings from enum import Enum from typing import Dict @@ -23,6 +24,7 @@ logger = logging.getLogger(__name__) +logging.captureWarnings(True) class EventType(Enum): @@ -132,7 +134,7 @@ def _get_experiment(self, name: str) -> Optional[Experiment]: self._cfg_data = self._get_config() if name not in self._cfg_data: - logger.info("Experiment <%r> not found in experiment config", name) + warnings.warn(f"Experiment <{repr(name)}> not found in experiment config", RuntimeWarning) return None try: From ddfcd6fd010c8806a88cd3c51f55332d857622c5 Mon Sep 17 00:00:00 2001 From: Jayme Howard Date: Mon, 17 May 2021 12:00:43 -0500 Subject: [PATCH 2/2] Fixes based on spladug feedback --- reddit_experiments/__init__.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/reddit_experiments/__init__.py b/reddit_experiments/__init__.py index 0aa2c6c..a5f962c 100644 --- a/reddit_experiments/__init__.py +++ b/reddit_experiments/__init__.py @@ -24,7 +24,6 @@ logger = logging.getLogger(__name__) -logging.captureWarnings(True) class EventType(Enum): @@ -134,7 +133,7 @@ def _get_experiment(self, name: str) -> Optional[Experiment]: self._cfg_data = self._get_config() if name not in self._cfg_data: - warnings.warn(f"Experiment <{repr(name)}> not found in experiment config", RuntimeWarning) + warnings.warn(f"Experiment <{repr(name)}> not found in experiment config") return None try: