Fix issues with IgnoreLocalhost on Podman upon local file changes

This makes sure we pass the value of the IgnoreLocalhost flag to the watch handler

Author: rm3l

pkg/dev/podmandev/podmandev.go

@@ -107,6 +107,7 @@ func (o *DevClient) Start(
 		DevfileRunCmd:       options.RunCommand,
 		Variables:           options.Variables,
 		RandomPorts:         options.RandomPorts,
+		IgnoreLocalhost:     options.IgnoreLocalhost,
 		WatchFiles:          options.WatchFiles,
 		WatchCluster:        false,
 		Out:                 out,
@@ -188,13 +189,14 @@ func (o *DevClient) watchHandler(ctx context.Context, pushParams adapters.PushPa
 	printWarningsOnDevfileChanges(ctx, watchParams)
 
 	startOptions := dev.StartOptions{
-		IgnorePaths:  watchParams.FileIgnores,
-		Debug:        watchParams.Debug,
-		BuildCommand: watchParams.DevfileBuildCmd,
-		RunCommand:   watchParams.DevfileRunCmd,
-		RandomPorts:  watchParams.RandomPorts,
-		WatchFiles:   watchParams.WatchFiles,
-		Variables:    watchParams.Variables,
+		IgnorePaths:     watchParams.FileIgnores,
+		Debug:           watchParams.Debug,
+		BuildCommand:    watchParams.DevfileBuildCmd,
+		RunCommand:      watchParams.DevfileRunCmd,
+		RandomPorts:     watchParams.RandomPorts,
+		IgnoreLocalhost: watchParams.IgnoreLocalhost,
+		WatchFiles:      watchParams.WatchFiles,
+		Variables:       watchParams.Variables,
 	}
 	return o.reconcile(ctx, watchParams.Out, watchParams.ErrOut, startOptions, componentStatus)
 }

pkg/watch/watch.go

@@ -90,6 +90,9 @@ type WatchParameters struct {
 	Variables map[string]string
 	// RandomPorts is true to forward containers ports on local random ports
 	RandomPorts bool
+	// IgnoreLocalhost indicates whether to proceed with port-forwarding regardless of any container ports being bound to the container loopback interface.
+	// Applicable to Podman only.
+	IgnoreLocalhost bool
 	// WatchFiles indicates to watch for file changes and sync changes to the container
 	WatchFiles bool
 	// WatchCluster indicates to watch Cluster-related objects (Deployment, Pod, etc)

tests/integration/cmd_dev_test.go

@@ -3466,6 +3466,36 @@ CMD ["npm", "start"]
 						}).Should(HaveOccurred())
 					})
 				})
+
+				When("making changes in the project source code during the dev session", func() {
+					BeforeEach(func() {
+						helper.ReplaceString(filepath.Join(commonVar.Context, "server.js"), "Hello from", "Hiya from the updated")
+						var err error
+						var bErr []byte
+						_, bErr, ports, err = devSession.WaitSync()
+						Expect(err).ShouldNot(HaveOccurred())
+						stderr = string(bErr)
+					})
+
+					It("should port-forward successfully", func() {
+						By("displaying warning message for loopback port", func() {
+							Expect(stderr).Should(ContainSubstring("Detected that the following port(s) can be reached only via the container loopback interface: admin (3001)"))
+						})
+						By("reaching the local port for the non-loopback interface", func() {
+							Eventually(func(g Gomega) {
+								g.Expect(ports["3000"]).Should(haveHttpResponse(http.StatusOK, "Hiya from the updated Node.js Application!"))
+							}).WithTimeout(60 * time.Second).WithPolling(3 * time.Second).Should(Succeed())
+						})
+						By("not succeeding to reach the local port for the loopback interface", func() {
+							// By design, Podman will not forward to container apps listening on localhost.
+							// See https://github.com/redhat-developer/odo/issues/6510 and https://github.com/containers/podman/issues/17353
+							Consistently(func() error {
+								_, err := http.Get("http://" + ports["3001"])
+								return err
+							}).Should(HaveOccurred())
+						})
+					})
+				})
 			})
 		})