Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preStop lifecycle event support #3566

Closed
upLukeWeston opened this issue Jul 14, 2020 · 1 comment · Fixed by #3631
Closed

preStop lifecycle event support #3566

upLukeWeston opened this issue Jul 14, 2020 · 1 comment · Fixed by #3631
Assignees
@maysunfaisal
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/user-story An issue of user-story kind

Comments

@upLukeWeston
Copy link
Contributor

User Story

As a stack creator, I want to be able to define commands that will be executed before my component is deleted as a part of odo delete (preStop events)

Acceptance Criteria

  • It should follow the specification as defined in devfile/kubernetes-api#32 to support execution of the commands based on the events.
  • preStop events should run before the component is deleted. Refer to design and discussions here for further details.

Links

/kind user-story
/area devfile
@openshift-ci-robot openshift-ci-robot added kind/user-story An issue of user-story kind area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. labels Jul 14, 2020
@neeraj-laad neeraj-laad mentioned this issue Jul 15, 2020
Closed
1 task
@maysunfaisal
Copy link
Contributor

will check if we need this issue or it can be covered by parent issue #3569 in a single sprint

This was referenced Jul 23, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maysunfaisal maysunfaisal

Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/user-story An issue of user-story kind
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PreStop Event Feature maysunfaisal/odo-fork
3 participants
@openshift-ci-robot @maysunfaisal @upLukeWeston