Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand E2E test case coverage - Creating multicomponent applications with odo #4356

Closed
2 tasks
rnapoles-rh opened this issue Jan 12, 2021 · 4 comments
Closed
2 tasks
Assignees
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering kind/user-story An issue of user-story kind

Comments

@rnapoles-rh
Copy link
Contributor

rnapoles-rh commented Jan 12, 2021

/kind user-story

User Story

Create end-to-end scenario to cover creation of multicomponent applications

Acceptance Criteria

  • At least two components are created and linked
  • for this story will cover s2i components as linking devfile components is not supported at this time (as per Dharmit's comment below)

/kind user-story

@openshift-ci-robot openshift-ci-robot added the kind/user-story An issue of user-story kind label Jan 12, 2021
@rnapoles-rh rnapoles-rh self-assigned this Jan 12, 2021
@dharmit
Copy link
Member

dharmit commented Jan 12, 2021

[ ] At least two components are linked

If this means using odo link to link two devfile components, I'm afraid it's not implmented yet. It's being tracked in #3423 which is waiting on #4159 which is blocked on devfile/api#216.

Hopefully I'm wrong. 🤞

@rnapoles-rh
Copy link
Contributor Author

rnapoles-rh commented Jan 12, 2021

I am starting with s2i components which I tried with odo link manually and works as expected Thanks for pointing out that devfile components linking is not implemented yet. I will create the corresponding tests when supported.

@dharmit
Copy link
Member

dharmit commented Jan 13, 2021

I am starting with s2i components which I tried with odo link manually and works as expected

We're not going to have an explicit s2i component once #4281 is addressed. And, AFAIK, @girishramnani has already started working on it.

What we'll have after that is addressed is odo automagically creating devfile.yaml for the user when they do odo create --s2i. So I'm not sure how much value will be added if we try to expand test scenarios for odo link between s2i components.

@rnapoles-rh rnapoles-rh added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label Jan 13, 2021
@rnapoles-rh
Copy link
Contributor Author

@dharmit thanks for pointing that. Closing it base on your input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering kind/user-story An issue of user-story kind
Projects
None yet
Development

No branches or pull requests

3 participants