From 1ca1f6ae22ac274ce55bc997f5b6e9803f58a0c9 Mon Sep 17 00:00:00 2001 From: Xia Tianyu Date: Sat, 12 Mar 2022 00:45:16 +0800 Subject: [PATCH 1/3] Remove redundant terser compress option See: https://github.com/terser/terser/blob/v5.10.0/tools/terser.d.ts#L14-L69 --- rollup.config.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/rollup.config.js b/rollup.config.js index c222025f4d..cb858d6761 100644 --- a/rollup.config.js +++ b/rollup.config.js @@ -98,8 +98,7 @@ export default [ compress: { pure_getters: true, unsafe: true, - unsafe_comps: true, - warnings: false + unsafe_comps: true } }) ] @@ -161,8 +160,7 @@ export default [ compress: { pure_getters: true, unsafe: true, - unsafe_comps: true, - warnings: false + unsafe_comps: true } }) ] From 7de767e0a14e71779271ff326b096053ad3af269 Mon Sep 17 00:00:00 2001 From: Xia Tianyu Date: Sat, 12 Mar 2022 02:54:23 +0800 Subject: [PATCH 2/3] Enable Intellisense for `rollup.config.js` See: https://github.com/rollup/rollup/blob/v2.70.0/docs/01-command-line-reference.md#config-intellisense --- rollup.config.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/rollup.config.js b/rollup.config.js index cb858d6761..3814e1ce55 100644 --- a/rollup.config.js +++ b/rollup.config.js @@ -1,3 +1,4 @@ +import { defineConfig } from 'rollup' import nodeResolve from '@rollup/plugin-node-resolve' import babel from '@rollup/plugin-babel' import replace from '@rollup/plugin-replace' @@ -22,7 +23,7 @@ const makeExternalPredicate = externalArr => { return id => pattern.test(id) } -export default [ +export default defineConfig([ // CommonJS { input: 'src/index.ts', @@ -165,4 +166,4 @@ export default [ }) ] } -] +]) From ff328f385b20a8a528368473cca9e418b4aa2226 Mon Sep 17 00:00:00 2001 From: Xia Tianyu Date: Sat, 12 Mar 2022 03:10:37 +0800 Subject: [PATCH 3/3] Simplify `external` generation in rollup config See: https://github.com/rollup/rollup/blob/v2.70.0/docs/999-big-list-of-options.md#external and https://github.com/rollup/rollup/blob/v2.70.0/src/rollup/types.d.ts#L528 --- rollup.config.js | 21 ++++++--------------- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/rollup.config.js b/rollup.config.js index 3814e1ce55..c96e6ad6ca 100644 --- a/rollup.config.js +++ b/rollup.config.js @@ -15,23 +15,17 @@ const babelRuntimeVersion = pkg.dependencies['@babel/runtime'].replace( '' ) -const makeExternalPredicate = externalArr => { - if (externalArr.length === 0) { - return () => false - } - const pattern = new RegExp(`^(${externalArr.join('|')})($|/)`) - return id => pattern.test(id) -} +const external = [ + ...Object.keys(pkg.dependencies || {}), + ...Object.keys(pkg.peerDependencies || {}) +].map(name => RegExp(`^${name}($|/)`)) export default defineConfig([ // CommonJS { input: 'src/index.ts', output: { file: 'lib/redux.js', format: 'cjs', indent: false }, - external: makeExternalPredicate([ - ...Object.keys(pkg.dependencies || {}), - ...Object.keys(pkg.peerDependencies || {}) - ]), + external, plugins: [ nodeResolve({ extensions @@ -52,10 +46,7 @@ export default defineConfig([ { input: 'src/index.ts', output: { file: 'es/redux.js', format: 'es', indent: false }, - external: makeExternalPredicate([ - ...Object.keys(pkg.dependencies || {}), - ...Object.keys(pkg.peerDependencies || {}) - ]), + external, plugins: [ nodeResolve({ extensions