Skip to content

Commit d125781

Browse files
committed
deps, v8: fix build torque on windows
On windows the torque binary needs to be compiled and linked with exception semantics and assume V8 is embedded Fixes: nodejs#57
1 parent 491eb0f commit d125781

File tree

1 file changed

+23
-0
lines changed

1 file changed

+23
-0
lines changed

deps/v8/gypfiles/v8.gyp

+23
Original file line numberDiff line numberDiff line change
@@ -2522,10 +2522,33 @@
25222522
'GCC_ENABLE_CPP_RTTI': 'YES', # -frtti
25232523
},
25242524
'defines': ['ANTLR4CPP_STATIC'],
2525+
'defines!': [
2526+
'_HAS_EXCEPTIONS=0',
2527+
'BUILDING_V8_SHARED=1',
2528+
],
25252529
'include_dirs': [
25262530
'../third_party/antlr4/runtime/Cpp/runtime/src',
25272531
'../src/torque',
25282532
],
2533+
# This is defined trough `configurations` for GYP+ninja compatibility
2534+
'configurations': {
2535+
'Debug': {
2536+
'msvs_settings': {
2537+
'VCCLCompilerTool': {
2538+
'RuntimeTypeInfo': 'true',
2539+
'ExceptionHandling': 1,
2540+
},
2541+
}
2542+
},
2543+
'Release': {
2544+
'msvs_settings': {
2545+
'VCCLCompilerTool': {
2546+
'RuntimeTypeInfo': 'true',
2547+
'ExceptionHandling': 1,
2548+
},
2549+
}
2550+
},
2551+
},
25292552
'sources': [
25302553
'../src/torque/TorqueBaseVisitor.cpp',
25312554
'../src/torque/TorqueBaseVisitor.h',

0 commit comments

Comments
 (0)