-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noticeable lag in setting active class on Link #1242
Comments
@NicholasGW Would you mind upgrading and testing your site on version 1.0.0-beta2? The current code implements the |
Do any components between the |
Link now listens to the history to know if its active, so they should be much faster now on re-renders, though time will tell if they are slower now to set up 😐 Closing and hoping for no new tickets to come in saying the new implementation is slow 🙏 |
@ryanflorence Do you still have this issue? Best, |
I have a page that has a pretty large render + lots of aysnc going on, but I haven't been able to diagnose the cause of this issue. When I click a new link, there is a long, noticeable delay in when the link adds the active class. It appears even after all the rendering and network activity as stopped, there can still be a long delay (5 seconds or so). Wondering if anyone else is experiencing this behaviour or has a workaround, otherwise I'm looking at imperatively modifying the class in componentDidMount for each of my sub-views.
Links are sidebar nav icons, and the active class gives them a shaded background, if that matters.
The text was updated successfully, but these errors were encountered: