activeClassName not working

[mxaly]

using React 0.12.0 when navigating, class to selected link is not added.

[ryanflorence]

can you provide a test case somewhere? it works in the examples in this repo.

[mxaly]

Weird... Looks like it's not working only in one case. I don't have separated example but since it's in public project, you can take a look:

router
tags
tag_nav - here it's not working
link - here it's working

I will investigate it later. Maybe it's just a bug in my app.

[gaearon]

@mxaly

Perhaps params={@props.tag} ought to be params={name: @props.tag}?

[mxaly]

tag is an object with name field inside so it should work that way or params={name: @props.tag.name}

[gaearon]

I was confused by apparently different usage in link.cjsx and tag_nav.cjsx (here presumably tag is a string?)

[mxaly]

yep, link have tags array(strings). tag_nav and related tag components use TagsStore where tags are objects. It could be confizing. Anyway i still can't get solution for that.

[gaearon]

Are you using react-bootstrap? This could be one of the problems with router depending on slightly broken feature (context) in React: #400 #470

[mxaly]

it's in package but i'm not using it (waiting for 0.12.0 compatibility). Pure bootstrap there css there for now

[gaearon]

Could you by any chance have several copies of React loaded? This often leads to obscure bugs, although I'm not at all sure about this one.

[mxaly]

what do you mean? I'm requiring react when it's needed. Could it be problem?

[gaearon]

@mxaly Basically you need to check if there's no react-router/node_modules/react (or react-bootstrap/node_modules/react, etc, you get the idea) because this would cause obscure bugs.

[mxaly]

oh, will do, thanks!

[ryanflorence]

I'm pretty confident this is working as designed, let use know if you discover anything that you think we need to fix.

[areim3r]

@ryanflorence is there a way to set the activeClassName for the containing li ? its working fine so I didn't feel it was worth opening a new issue but say for bootstrap pills navigation, you set the active class on the li not the a, which means that by default the bootstrap active class won't work. there is this component which is supposed to do that but it seems it doesn't work as of react-router v1.0