doesnt work with pure render mixin

[yocontra]

since the route is essentially a new form of state the react pure render mixin doesn't work out of the box. i wrote one that does work that could be used instead

'use strict';

var shallowEqual = require('react/lib/shallowEqual');
var lastPath;

module.exports = {
  shouldComponentUpdate: function(nextProps, nextState) {
    // component is route-able
    var routeChanged = this.getPath && didPathChange(this.getPath());
    return routeChanged ||
      !shallowEqual(this.props, nextProps) ||
      !shallowEqual(this.state, nextState);
  }
};

function didPathChange(currPath) {
  var pathChanged = lastPath !== currPath;
  lastPath = currPath;
  return pathChanged;
}

not sure if this is just a documentation item or something you want to put in the repo

[gaearon]

I believe this to be a duplicate of #470. I currently solve this by having my own mixin where I explicitly subscribe to my own RouterStore so it gets into state.

Really, the underlying issue is React's: facebook/react#2517

[yocontra]

cool - didnt get anything when i searched for "pure" but that is def a duplicate. will keep an eye on that

[tajo]

ES6 style solution: https://github.com/tajo/este/blob/master/src/lib/linkcomponent.js

[CezaryDanielNowak]

This issue still occours