chore(lint): add object shortand rule (#18080)

Author: RahulGautamSingh

.eslintrc.js

@@ -133,6 +133,13 @@ module.exports = {
 
     'typescript-enum/no-const-enum': 2,
     'typescript-enum/no-enum': 2,
+    'object-shorthand': [
+      'error',
+      'always',
+      {
+        avoidQuotes: true,
+      },
+    ],
   },
   settings: {
     'import/parsers': {

lib/modules/datasource/conda/index.ts

@@ -51,7 +51,7 @@ export class CondaDatasource extends Datasource {
 
       response.body.versions.forEach((version: string) => {
         const thisRelease: Release = {
-          version: version,
+          version,
         };
         result.releases.push(thisRelease);
       });

lib/modules/datasource/github-releases/cache/cache-base.spec.ts

@@ -194,7 +194,7 @@ describe('modules/datasource/github-releases/cache/cache-base', () => {
     const createdAt = now.minus({ minutes: 119 }).toISO();
     packageCache.get.mockResolvedValueOnce({
       items: { v1: { version: 'v1', releaseTimestamp, bar: 'aaa' } },
-      createdAt: createdAt,
+      createdAt,
       updatedAt: createdAt,
     });
     responses = [
@@ -219,7 +219,7 @@ describe('modules/datasource/github-releases/cache/cache-base', () => {
     const createdAt = now.minus({ minutes: 120 }).toISO();
     packageCache.get.mockResolvedValueOnce({
       items: { v1: { version: 'v1', releaseTimestamp, bar: 'aaa' } },
-      createdAt: createdAt,
+      createdAt,
       updatedAt: createdAt,
     });
     responses = [
@@ -240,7 +240,7 @@ describe('modules/datasource/github-releases/cache/cache-base', () => {
       'test-cache',
       'https://api.github.com/:foo:bar',
       {
-        createdAt: createdAt,
+        createdAt,
         items: {
           v1: { bar: 'aaa', releaseTimestamp, version: 'v1' },
           v2: { bar: 'bbb', releaseTimestamp: recentTimestamp, version: 'v2' },

lib/modules/datasource/github-tags/index.ts

@@ -56,7 +56,7 @@ export class GithubTagsDatasource extends Datasource {
       digest = res.body[0].sha;
     } catch (err) {
       logger.debug(
-        { githubRepo: githubRepo, err, registryUrl },
+        { githubRepo, err, registryUrl },
         'Error getting latest commit from GitHub repo'
       );
     }

lib/modules/datasource/index.spec.ts

@@ -184,7 +184,7 @@ describe('modules/datasource/index', () => {
       datasources.set(datasource, new DummyDatasource());
       expect(
         await getPkgReleases({
-          datasource: datasource,
+          datasource,
           depName: null as never, // #7154
         })
       ).toBeNull();
@@ -247,9 +247,9 @@ describe('modules/datasource/index', () => {
 
       expect(
         await getDigest({
-          datasource: datasource,
+          datasource,
           packageName: 'pkgName',
-          depName: depName,
+          depName,
           replacementName: 'replacement',
         })
       ).toBe('replacement');

lib/modules/datasource/maven/index.spec.ts

@@ -215,7 +215,7 @@ describe('modules/datasource/maven/index', () => {
       snapshots: [
         {
           version: '1.0.3-SNAPSHOT',
-          meta: meta,
+          meta,
           jarStatus: 200,
         },
       ],

lib/modules/manager/bazel/parser.ts

@@ -68,7 +68,7 @@ const kwParams = q
       ctx.currentTarget[ctx.currentAttrKey!] = value;
       ctx.result.meta.push({
         path: [...ctx.currentMetaPath],
-        data: { offset: offset, length: value.length },
+        data: { offset, length: value.length },
       });
       return ctx;
     }),
@@ -83,7 +83,7 @@ const kwParams = q
       search: q.str<Ctx>((ctx, { value, offset }) => {
         ctx.result.meta.push({
           path: [...ctx.currentMetaPath, ctx.currentArray!.length],
-          data: { offset: offset, length: value.length },
+          data: { offset, length: value.length },
         });
         ctx.currentArray?.push(value);
         return ctx;

lib/modules/manager/buildkite/extract.ts

@@ -32,7 +32,7 @@ export function extractPackageFile(content: string): PackageFile | null {
           const gitDepName = gitPluginName.replace(regEx('\\.git$'), '');
           const dep: PackageDependency = {
             depName: gitDepName,
-            currentValue: currentValue,
+            currentValue,
             registryUrls: ['https://' + registry],
             datasource: GithubTagsDatasource.id,
           };

lib/modules/manager/flux/extract.ts

@@ -18,15 +18,15 @@ function readManifest(content: string, file: string): FluxManifest | null {
     }
     return {
       kind: 'system',
-      file: file,
+      file,
       version: versionMatch[1],
       components: versionMatch[2],
     };
   }
 
   const manifest: FluxManifest = {
     kind: 'resource',
-    file: file,
+    file,
     releases: [],
     repositories: [],
   };
@@ -128,7 +128,7 @@ export function extractPackageFile(
     return null;
   }
   const deps = resolveManifest(manifest, [manifest]);
-  return deps?.length ? { deps: deps } : null;
+  return deps?.length ? { deps } : null;
 }
 
 export async function extractAllPackageFiles(
@@ -152,7 +152,7 @@ export async function extractAllPackageFiles(
     if (deps?.length) {
       results.push({
         packageFile: manifest.file,
-        deps: deps,
+        deps,
       });
     }
   }

lib/modules/manager/gradle/extract/catalog.ts

@@ -88,7 +88,7 @@ function extractVersion({
     });
   } else {
     return extractLiteralVersion({
-      version: version,
+      version,
       depStartIndex,
       depSubContent,
       sectionKey: depName,

lib/modules/manager/hermit/artifacts.ts

@@ -220,7 +220,7 @@ async function updateHermitPackage(update: UpdateArtifact): Promise<void> {
   logger.debug(
     {
       packageFile: update.packageFileName,
-      packagesToInstall: packagesToInstall,
+      packagesToInstall,
     },
     `performing updates`
   );

lib/modules/manager/mint/extract.ts

@@ -36,7 +36,7 @@ function handleDepInMintfile(line: string): PackageDependency {
   }
   const [depName, currentVersion] = line.split('@').map((s) => s.trim());
   return {
-    depName: depName,
+    depName,
     currentValue: currentVersion,
     datasource: GitTagsDatasource.id,
     packageName: `https://github.com/${depName}.git`,

lib/modules/manager/npm/update/locked-dependency/package-lock/index.ts

@@ -127,7 +127,7 @@ export async function updateLockedDependency(
         files[packageFile!] = packageFileContent!;
         // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
         files[lockFile!] = lockFileContent!;
-        return { status, files: files };
+        return { status, files };
       }
       return { status };
     }

lib/modules/manager/poetry/extract.ts

@@ -57,7 +57,7 @@ function extractFromSection(
     const dep: PackageDependency = {
       depName,
       depType: section,
-      currentValue: currentValue,
+      currentValue,
       managerData: { nestedVersion },
       datasource: PypiDatasource.id,
     };

lib/modules/manager/setup-cfg/extract.ts

@@ -75,7 +75,7 @@ function parseDep(
     depName,
     currentValue,
     datasource: PypiDatasource.id,
-    depType: depType,
+    depType,
   };
 
   if (currentValue?.startsWith('==')) {

lib/modules/platform/azure/azure-helper.spec.ts

@@ -82,7 +82,7 @@ describe('modules/platform/azure/azure-helper', () => {
       const mockEventStream = new Readable({
         objectMode: true,
 
-        read: function () {
+        read() {
           if (eventCount < 1) {
             eventCount += 1;
             return this.push('{"typeKey": "GitItemNotFoundException"}');
@@ -111,7 +111,7 @@ describe('modules/platform/azure/azure-helper', () => {
       const mockEventStream = new Readable({
         objectMode: true,
 
-        read: function () {
+        read() {
           if (eventCount < 1) {
             eventCount += 1;
             return this.push('{"typeKey": "GitUnresolvableToCommitException"}');
@@ -140,7 +140,7 @@ describe('modules/platform/azure/azure-helper', () => {
       const mockEventStream = new Readable({
         objectMode: true,
 
-        read: function () {
+        read() {
           if (eventCount < 1) {
             eventCount += 1;
             return this.push('{"hello"= "test"}');

lib/modules/platform/bitbucket-server/index.spec.ts

@@ -2114,7 +2114,7 @@ Followed by some information.
             )
             .reply(200, {
               isLastPage: true,
-              lines: lines,
+              lines,
             });
           const res = await bitbucket.getJsonFile('file.json5');
           expect(res).toEqual({ foo: 'bar' });

lib/modules/platform/bitbucket-server/utils.spec.ts

@@ -120,8 +120,8 @@ describe('modules/platform/bitbucket-server/utils', () => {
         const username = 'abc';
         const password = '123';
         const opts = {
-          username: username,
-          password: password,
+          username,
+          password,
         };
 
         it('works gitUrl:undefined generate endpoint', () => {

lib/modules/versioning/hermit/index.ts

@@ -52,8 +52,8 @@ export class HermitVersioning extends RegExpVersioningApi {
 
     return {
       release,
-      prerelease: prerelease,
-      compatibility: compatibility,
+      prerelease,
+      compatibility,
     };
   }
 

lib/modules/versioning/node/schedule.ts

@@ -22,7 +22,7 @@ for (const version of Object.keys(nodeSchedule)) {
   const schedule = nodeSchedule[version];
   if (schedule.codename) {
     nodeCodenames.set(schedule.codename.toUpperCase(), {
-      version: version,
+      version,
       ...schedule,
     });
   }

lib/modules/versioning/regex/index.ts

@@ -84,8 +84,8 @@ export class RegExpVersioningApi extends GenericVersioningApi<RegExpVersion> {
 
     return {
       release,
-      prerelease: prerelease,
-      compatibility: compatibility,
+      prerelease,
+      compatibility,
     };
   }
 

lib/util/common.ts

@@ -20,7 +20,7 @@ export function detectPlatform(url: string): 'gitlab' | 'github' | null {
     return 'gitlab';
   }
 
-  const hostType = hostRules.hostType({ url: url });
+  const hostType = hostRules.hostType({ url });
 
   if (!hostType) {
     return null;

lib/util/git/index.spec.ts

@@ -262,7 +262,7 @@ describe('util/git/index', () => {
       const parentSha = 'SHA';
       const branchCache = partial<BranchCache>({
         branchName: 'develop',
-        parentSha: parentSha,
+        parentSha,
       });
       repoCache.getCache.mockReturnValueOnce({}).mockReturnValueOnce({
         branches: [branchCache],

lib/workers/repository/config-migration/branch/create.spec.ts

@@ -78,7 +78,7 @@ describe('workers/repository/config-migration/branch/create', () => {
             contents: renovateConfig,
           },
         ],
-        message: message,
+        message,
         platformCommit: false,
       });
     });
@@ -101,7 +101,7 @@ describe('workers/repository/config-migration/branch/create', () => {
               contents: renovateConfig,
             },
           ],
-          message: message,
+          message,
           platformCommit: false,
         });
       });
@@ -125,7 +125,7 @@ describe('workers/repository/config-migration/branch/create', () => {
               contents: renovateConfig,
             },
           ],
-          message: message,
+          message,
           platformCommit: false,
         });
       });
@@ -150,7 +150,7 @@ describe('workers/repository/config-migration/branch/create', () => {
               contents: renovateConfig,
             },
           ],
-          message: message,
+          message,
           platformCommit: false,
         });
       });
@@ -174,7 +174,7 @@ describe('workers/repository/config-migration/branch/create', () => {
               contents: renovateConfig,
             },
           ],
-          message: message,
+          message,
           platformCommit: false,
         });
       });

lib/workers/repository/update/pr/body/index.spec.ts

@@ -233,7 +233,7 @@ describe('workers/repository/update/pr/body/index', () => {
           manager: 'some-manager',
           branchName: 'some-branch',
           upgrades: [],
-          packageFiles: packageFiles,
+          packageFiles,
           prBodyTemplate: '{{{warnings}}}',
         },
         {