Skip to content

Commit 04a540e

Browse files
committed
Revert "fix issue #60"
This reverts commit 397cdc1.
1 parent 650fa7a commit 04a540e

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

src/pull/labeled.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -142,12 +142,12 @@ module.exports.process = (robot) => async ({
142142
(s) =>
143143
s.conclusion !== CONCLUSION.SUCCESS &&
144144
s.conclusion !== CONCLUSION.NEUTRAL &&
145-
s.conclusion !== CONCLUSION.SKIPPED
146-
// Currently check suites like https://github.com/NLog/NLog/pull/3296/checks were being
147-
// queued and never concluding. You can see that in this API response:
148-
// https://api.github.com/repos/NLog/Nlog/commits/2c8f7471648f22fa5dc9bf6db53e96fae061fc0a/check-suites
149-
// Corresponding issue: https://github.com/mfix22/ranger/issues/60
150-
// s.conclusion !== null
145+
s.conclusion !== CONCLUSION.SKIPPED &&
146+
// TODO remove this. Currently check suites like https://github.com/NLog/NLog/pull/3296/checks are being
147+
// queued and never concluding. You can see that in this API response:
148+
// https://api.github.com/repos/NLog/Nlog/commits/2c8f7471648f22fa5dc9bf6db53e96fae061fc0a/check-suites
149+
// Corresponding issue: https://github.com/mfix22/ranger/issues/60
150+
s.conclusion !== null
151151
)
152152
) {
153153
throw new Retry()

test/index.test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -605,7 +605,7 @@ describe('pull_request', () => {
605605
})
606606

607607
test.each([
608-
// [null, true], was used for https://github.com/dawnlabs/ranger/issues/60
608+
[null, true], // TODO https://github.com/dawnlabs/ranger/issues/60
609609
[CONCLUSION.SUCCESS, true],
610610
[CONCLUSION.NEUTRAL, true],
611611
[CONCLUSION.TIMED_OUT, false],

0 commit comments

Comments
 (0)