clean up create tag code

- Makes sure config is checked first before releases are fetched

Author: mfix22

src/pull/merged.js

@@ -31,13 +31,28 @@ module.exports.createTag = () => async context => {
   // Only create tags on "master"
   if (thread.base.ref !== context.payload.repository.default_branch) return
 
-  const { data } = await context.github.repos.listTags(context.repo({ per_page: 1 }))
+  const isMajor = thread.labels.find(({ name }) => name.toLowerCase().includes('major'))
+  const isMinor = thread.labels.find(({ name }) => name.toLowerCase().includes('minor'))
+  const isPatch = thread.labels.find(({ name }) => name.toLowerCase().includes('patch'))
 
-  if (!(data && data[0] && data[0].name)) return
+  if (!(isMajor || isMinor || isPatch)) {
+    const config = await getConfig(context)
+    const isAutoPatch =
+      Array.isArray(config.merges) &&
+      config.merges.find(c => {
+        const value = c.action || c
+        return typeof value === 'string' && value.trim().toLowerCase() === TAG
+      })
 
-  const lastTag = data[0].name
+    if (!isAutoPatch) return
+  }
 
-  const match = /(v{0,1})(\d+)\.(\d+)\.(\d+)/.exec(lastTag)
+  const { data } = await context.github.repos.listTags(context.repo({ per_page: 1 }))
+
+  const previousTag = data && data[0] && data[0].name
+  if (!previousTag) return
+
+  const match = /(v{0,1})(\d+)\.(\d+)\.(\d+)/.exec(previousTag)
 
   if (!match) return
 
@@ -48,27 +63,13 @@ module.exports.createTag = () => async context => {
     patch: Number(match[4])
   }
 
-  const config = await getConfig(context)
-
-  const isMajor = thread.labels.find(({ name }) => name.toLowerCase().includes('major'))
-  const isMinor = thread.labels.find(({ name }) => name.toLowerCase().includes('minor'))
-  const isPatch = thread.labels.find(({ name }) => name.toLowerCase().includes('patch'))
-  const isAutoPatch =
-    Array.isArray(config.merges) &&
-    config.merges.find(c => {
-      const value = c.action || c
-      return typeof value === 'string' && value.trim().toLowerCase() === TAG
-    })
-
   let tag
   if (isMajor) {
     tag = `${v.v}${v.major + 1}.0.0`
   } else if (isMinor) {
     tag = `${v.v}${v.major}.${v.minor + 1}.0`
-  } else if (isPatch || isAutoPatch) {
-    tag = `${v.v}${v.major}.${v.minor}.${v.patch + 1}`
   } else {
-    return
+    tag = `${v.v}${v.major}.${v.minor}.${v.patch + 1}`
   }
 
   const sha = thread.merge_commit_sha