Merge pull request #31 from dawnlabs/commit-body

WIP react to new commit bodies

Author: repo-ranger[bot]

index.js

@@ -7,6 +7,7 @@ const threadLabeled = require('./src/thread/labeled')
 const issueLabeled = require('./src/issue/labeled')
 const pullLabeled = require('./src/pull/labeled')
 const pullMerged = require('./src/pull/merged')
+const pullSynchronized = require('./src/pull/synchronized')
 const threadClosed = require('./src/thread/closed')
 const commentDeleted = require('./src/comment/deleted')
 const commentCreated = require('./src/comment/created')
@@ -86,6 +87,8 @@ module.exports = async robot => {
 
   robot.on('pull_request.closed', wrapPaymentCheck(pullMerged()))
 
+  robot.on('pull_request.synchronize', pullSynchronized())
+
   // Kill job when issue/pull is closed
   robot.on(['issues.closed', 'pull_request.closed'], threadClosed(queue))
 

src/config.js

@@ -1,6 +1,6 @@
 const ms = require('ms')
 
-const { CLOSE, MERGE } = require('./constants')
+const { CLOSE, MERGE, LABEL } = require('./constants')
 
 const TIME = process.env.NODE_ENV === 'production' ? '7 days' : '10s'
 
@@ -19,7 +19,14 @@ const defaultConfig = {
     invalid: CLOSE,
     'merge when passing': MERGE
   },
-  comments: []
+  comments: [],
+  commits: [
+    {
+      action: LABEL,
+      pattern: '/merge when passing/i',
+      labels: ['merge when passing']
+    }
+  ]
 }
 
 exports.CONFIG_FILE = CONFIG_FILE

src/pull/synchronized.js

@@ -0,0 +1,51 @@
+const { LABEL, MAINTAINERS } = require('../constants')
+const getConfig = require('../config')
+const { addLabels } = require('../api')
+
+function isMaintainer(association) {
+  return MAINTAINERS.includes(association)
+}
+
+function parseRegex(string) {
+  // https://stackoverflow.com/questions/874709/converting-user-input-string-to-regular-expression
+  const match = string.match(new RegExp('^/(.*?)/([gimy]*)$'))
+
+  if (match && match[1] && match[2]) {
+    return new RegExp(match[1], match[2])
+  }
+
+  // matches nothing
+  return /$^/
+}
+
+module.exports = () => async context => {
+  const config = await getConfig(context)
+
+  const {
+    head: { sha },
+    author_association
+  } = context.payload.pull_request
+
+  if (!isMaintainer(author_association)) return
+
+  const {
+    data: {
+      commit: { message: body }
+    }
+  } = await context.github.repos.getCommit(context.repo({ sha }))
+
+  // TODO confirm this API before releasing in docs
+  const rules = config.commits
+
+  if (!Array.isArray(rules)) return
+
+  await Promise.all(
+    rules.map(async ({ action, pattern, labels } = {}) => {
+      if (typeof action !== 'string' || action.trim().toLowerCase() !== LABEL) return
+      if (!body.includes(pattern) && !parseRegex(pattern).test(body)) return
+      if (!labels) return
+
+      return addLabels(context.github, context.issue({ labels }))
+    })
+  )
+}

test/fixtures/synchronized.js

@@ -0,0 +1,22 @@
+module.exports = ({ author_association = 'COLLABORATOR' } = {}) => ({
+  name: 'pull_request',
+  payload: {
+    action: 'synchronize',
+    pull_request: {
+      number: 4,
+      head: {
+        sha: 'e829d1a59ce17e24fee7b8ffa42774005acd0240'
+      },
+      author_association
+    },
+    repository: {
+      id: 130609983,
+      name: 'ranger-test',
+      full_name: 'ranger/ranger-test',
+      owner: {
+        login: 'ranger'
+      },
+      private: false
+    }
+  }
+})

test/index.test.js

@@ -6,6 +6,7 @@ const payload = require('./fixtures/labeled')
 const commentPayload = require('./fixtures/comment')
 const addedPayload = require('./fixtures/added')
 const installedPayload = require('./fixtures/installed')
+const synchronizedPayload = require('./fixtures/synchronized')
 
 const { MAINTAINERS } = require('../src/constants')
 
@@ -131,6 +132,12 @@ comments:
 merges:
   - action: delete_branch
 
+commits:
+  - action: label
+    pattern: /merge when passing/i
+    labels:
+      - merge when passing
+
 default:
   close:
     delay: 1ms
@@ -167,7 +174,10 @@ describe('Bot', () => {
       },
       repos: {
         getContent: jest.fn(() => ({ data: { content: Buffer.from(config).toString('base64') } })),
-        getContents: jest.fn(() => ({ data: { content: Buffer.from(config).toString('base64') } }))
+        getContents: jest.fn(() => ({ data: { content: Buffer.from(config).toString('base64') } })),
+        getCommit: jest
+          .fn()
+          .mockResolvedValue({ data: { commit: { message: 'merge when passing' } } })
       },
       apps: {
         listRepos: jest.fn().mockResolvedValue({
@@ -479,6 +489,26 @@ describe('Bot', () => {
         repo: 'Hello-World'
       })
     })
+
+    test('Will take action on a maintainer commit message', async () => {
+      await robot.receive(synchronizedPayload())
+
+      expect(github.issues.addLabels).toHaveBeenCalledWith({
+        number: 4,
+        labels: ['merge when passing'],
+        owner: 'ranger',
+        repo: 'ranger-test',
+        headers: {
+          Accept: 'application/vnd.github.symmetra-preview+json'
+        }
+      })
+    })
+
+    test('Will not take action on a non-maintainer commit message', async () => {
+      await robot.receive(synchronizedPayload({ author_association: 'CONTRIBUTOR' }))
+
+      expect(github.issues.addLabels).not.toHaveBeenCalled()
+    })
   })
 
   describe('comment', () => {