Skip to content

Problem with Restyler Job #4532593 #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kiyarose opened this issue Jun 22, 2024 · 2 comments
Closed

Problem with Restyler Job #4532593 #233

kiyarose opened this issue Jun 22, 2024 · 2 comments

Comments

@kiyarose
Copy link

Greetings-

I'm having a problem with a Restyled Job

What I expected to happen:

Restyle to complete successfully, or to ignore as it cannot make any applicable changes.

What happened instead:

Restyled returns an error after cloning repository

info     Restyler started                owner="dswan36" pull=6 repo="ezprox"
debug    fatal: Couldn't find remote ref pull/6/head
info     Cloning repository             
error    Exception:
callProcess: git "fetch" "--quiet" "--depth" "1" "origin" "pull/6/head:pull-6" (exit 128): failed error={description:"internal error",exitCode:99,severity:"critical",tag:"unknown"}
info     Restyler done                   exitCode=99

Restyled Seems to have tried to possibly pull data that doesn't exist yet? (I'm not sure)
I haven't extensively tested how often this could occur, so I cannot give many details on repro.
This is a friendly notification in case something went wrong, and information can be provided.

Configuration (if applicable):

Configuration is not specified in the repo in question, and therefor is assumed to be default.

@pbrisbin
Copy link
Member

pbrisbin commented Jun 24, 2024

Hi there-

Restyled Seems to have tried to possibly pull data that doesn't exist yet? (I'm not sure)

So far this is our best guess at what has happened. GitHub is sending us a webhook of the PR event, but its git systems have not made the PR ref available for cloning yet.

I do not think there is a real fix for this issue, it is just a state that can occur in distributed systems. The only thing we could do is implement some kind of retry-back-off on this particular exception.

Unfortunately, given the infrequency and intermittent-ness of this error, we don't have the bandwidth to work on it at this time. But we are fully open source, and would happily accept a PR in this space. The clone logic kicks off around here.

I've also added a new page on our Wiki. For now, I think this is the best we can do so I'm going to close this Issue. But thank you for reporting.

@kiyarose
Copy link
Author

So far this is our best guess at what has happened. GitHub is sending us a webhook of the PR event, but its git systems have not made the PR ref available for cloning yet.

I do not think there is a real fix for this issue, it is just a state that can occur in distributed systems. The only thing we could do is implement some kind of retry-back-off on this particular exception.

Another possible solution, could possibly be to wait X time before trying to pull after the web-hook sends the payload, but given it's not known how inconsistent the ttl for the head can be, that might not be super helpful.

I appreciate your response however, and the wiki page on it.

For now #162 's workaround should most likely also work.
Any solution is tough without resources, but the information is helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants