Skip to content

Commit b0b9318

Browse files
author
John Spray
committedJul 20, 2017
doc: add doc requirements on PR submitters
Signed-off-by: John Spray <[email protected]>
1 parent eb26360 commit b0b9318

File tree

2 files changed

+43
-3
lines changed

2 files changed

+43
-3
lines changed
 

‎SubmittingPatches.rst

+18-2
Original file line numberDiff line numberDiff line change
@@ -470,15 +470,31 @@ in your patch description.
470470
If you cannot condense your patch set into a smaller set of patches,
471471
then only post say 15 or so at a time and wait for review and integration.
472472

473+
5. Document your changes
474+
------------------------
475+
476+
If you have added or modified any user-facing functionality, such
477+
as CLI commands or their output, then the patch series or pull request
478+
must include appropriate updates to documentation.
479+
480+
It is the submitter's responsibility to make the changes, and the reviewer's
481+
responsibility to make sure they are not merging changes that do not
482+
have the needed updates to documentation.
483+
484+
Where there are areas that have absent documentation, or there is no
485+
clear place to note the change that is being made, the reviewer should
486+
contact the component lead, who should arrange for the missing section
487+
to be created with sufficient detail for the patch submitter to
488+
document their changes.
473489

474-
5. Style check your changes
490+
6. Style check your changes
475491
---------------------------
476492

477493
Check your patch for basic style violations, details of which can be
478494
found in CodingStyle.
479495

480496

481-
6. No MIME, no links, no compression, no attachments. Just plain text
497+
7. No MIME, no links, no compression, no attachments. Just plain text
482498
----------------------------------------------------------------------
483499

484500
Developers need to be able to read and comment on the changes you are

‎doc/dev/documenting.rst

+25-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,28 @@
22
Documenting Ceph
33
==================
44

5+
User documentation
6+
==================
7+
8+
The documentation on docs.ceph.com is generated from the restructuredText
9+
sources in ``/doc/`` in the Ceph git repository.
10+
11+
Please make sure that your changes are written in a way that is intended
12+
for end users of the software, unless you are making additions in
13+
``/doc/dev/``, which is the section for developers.
14+
15+
All pull requests that modify user-facing functionality must
16+
include corresponding updates to documentation: see
17+
`Submitting Patches`_ for more detail.
18+
19+
Check your .rst syntax is working as expected by using the "View"
20+
button in the github user interface when looking at a diff on
21+
an .rst file, or build the docs locally using the ``admin/build-doc``
22+
script.
23+
24+
For more information about the Ceph documentation, see
25+
:doc:`/start/documenting-ceph`.
26+
527
Code Documentation
628
==================
729

@@ -48,7 +70,7 @@ You can use Graphviz_, as explained in the `Graphviz extension documentation`_.
4870
digraph "example" {
4971
foo -> bar;
5072
bar -> baz;
51-
bar -> thud;
73+
bar -> th
5274
}
5375

5476
Most of the time, you'll want to put the actual DOT source in a
@@ -106,3 +128,5 @@ By committing the SVG file, others will be able to update the
106128
SVG diagrams using Inkscape.
107129

108130
HTML5 will support SVG inline.
131+
132+
.. _Submitting Patches: /SubmittingPatches.rst

0 commit comments

Comments
 (0)
Please sign in to comment.