Skip to content

Commit fb621e0

Browse files
committedOct 8, 2019
build: make full-icu the default for releases
Release builds specifically set the `--with-intl=` configure option instead of relying on the default. Explicitly set to `full-icu`. Refs: nodejs#29522
1 parent 064e111 commit fb621e0

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed
 

‎Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ NPM ?= ./deps/npm/bin/npm-cli.js
5252

5353
# Flags for packaging.
5454
BUILD_DOWNLOAD_FLAGS ?= --download=all
55-
BUILD_INTL_FLAGS ?= --with-intl=small-icu
55+
BUILD_INTL_FLAGS ?= --with-intl=full-icu
5656
BUILD_RELEASE_FLAGS ?= $(BUILD_DOWNLOAD_FLAGS) $(BUILD_INTL_FLAGS)
5757

5858
# Default to quiet/pretty builds.

‎vcbuild.bat

+2-2
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ if /i "%1"=="lint-md-build" set lint_md_build=1&goto arg-ok
120120
if /i "%1"=="lint" set lint_cpp=1&set lint_js=1&set lint_md=1&goto arg-ok
121121
if /i "%1"=="lint-ci" set lint_cpp=1&set lint_js_ci=1&goto arg-ok
122122
if /i "%1"=="package" set package=1&goto arg-ok
123-
if /i "%1"=="msi" set msi=1&set licensertf=1&set download_arg="--download=all"&set i18n_arg=small-icu&goto arg-ok
123+
if /i "%1"=="msi" set msi=1&set licensertf=1&set download_arg="--download=all"&set i18n_arg=full-icu&goto arg-ok
124124
if /i "%1"=="build-release" set build_release=1&set sign=1&goto arg-ok
125125
if /i "%1"=="upload" set upload=1&goto arg-ok
126126
if /i "%1"=="small-icu" set i18n_arg=%1&goto arg-ok
@@ -158,7 +158,7 @@ if defined build_release (
158158
set msi=1
159159
set licensertf=1
160160
set download_arg="--download=all"
161-
set i18n_arg=small-icu
161+
set i18n_arg=full-icu
162162
set projgen=1
163163
set cctest=1
164164
set ltcg=1

0 commit comments

Comments
 (0)
Please sign in to comment.