Skip to content

Commit 8123022

Browse files
committed
Remove --title from certain executables
See nodejs/node#41103
1 parent 52c17a3 commit 8123022

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

npm/BUILD.bazel

-1
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,4 @@ nodejs_binary(
2626
dep = "@better_rules_javascript_npm//@yarnpkg/cli-dist:lib",
2727
main = "bin/yarn.js",
2828
node = "//rules:nodejs",
29-
node_options = ["--title=yarn"],
3029
)

webpack/rules.bzl

+2-2
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ def configure_webpack(name, cli, webpack, dev_server, config, config_dep, node_o
110110
node = "@better_rules_javascript//rules:nodejs",
111111
name = "%s.bin" % name,
112112
dep = ":%s.main" % name,
113-
node_options = ["--title=webpack"] + node_options,
113+
node_options = node_options,
114114
visibility = ["//visibility:private"],
115115
)
116116

@@ -122,7 +122,7 @@ def configure_webpack(name, cli, webpack, dev_server, config, config_dep, node_o
122122

123123
nodejs_binary(
124124
name = "%s.server_bin" % name,
125-
node_options = ["--title=webpack"] + node_options,
125+
node_options = node_options,
126126
main = "src/main.js",
127127
node = "@better_rules_javascript//rules:nodejs",
128128
dep = ":%s.server_main" % name,

0 commit comments

Comments
 (0)