Skip to content

Plugin stopped working after eac476d0 on macOS #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rafi opened this issue Aug 16, 2021 · 4 comments · Fixed by #54
Closed

Plugin stopped working after eac476d0 on macOS #53

rafi opened this issue Aug 16, 2021 · 4 comments · Fixed by #54

Comments

@rafi
Copy link

rafi commented Aug 16, 2021

Hi there. After the eac476d commit, I'm unable to save session. I'm using macOS, and since this commit:

==== Pager mode false
sessions dir or file nil
==== Using session DIR
==== Session Name \%Users\%rafi\%src\%bla\%foo
==== is_readable false
==== is_readable false
File not readable, not restoring session
sessions dir or file nil
==== Using session DIR
==== Session Name \%Users\%rafi\%src\%bla\%foo
==== is_readable false
==== is_readable false
File not readable, not restoring session
SaveSession param is not a directory, saving as a file.
Session saved at

Session is saved in current path as Session.vim, not what expected.

@wilriker
Copy link
Contributor

I can see the same behavior on Linux. In addition I can see the following error message thrown by nvim:

E5108: Error executing lua ...site/pack/packer/start/auto-session/lua/auto-session.lua:178: attempt to concatenate local 'session' (a nil value)

What happens (AFAICT) is that the new local session is initialized from an empty value sessions_dir. And while sessions_dir is checked on the following line if it is empty and then being overwritten with the return value of AutoSession.get_root_dir() this won't affect the emptiness of session and nvim complains about concatenating a nil value.

@rmagatti rmagatti linked a pull request Aug 16, 2021 that will close this issue
@rmagatti
Copy link
Owner

Yeah fixed by #54.
That was my bad.

This reminds me I should come up with tests for the plugin so I don't break core functionality in the future.

@rmagatti rmagatti mentioned this issue Aug 16, 2021
@rmagatti
Copy link
Owner

@rafi @wilriker lmk if the fix doesn't work 🙏

@wilriker
Copy link
Contributor

I can confirm it works again for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants