Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem when running get_contributors with URL checks #46

Closed
maelle opened this issue Oct 11, 2024 · 1 comment
Closed

problem when running get_contributors with URL checks #46

maelle opened this issue Oct 11, 2024 · 1 comment

Comments

@maelle
Copy link
Member

maelle commented Oct 11, 2024

str(allcontributors::get_contributors("igraph", "rigraph"))
#> ★  Extracting code contributors
#> ✔ Extracted code contributors
#> ★  Extracting github issue contributors
#> ✔ Extracted github issue contributors
#> ★  Checking GitHub URLs
#> ✔ Checked GitHub URLs
#> 'data.frame':    29 obs. of  4 variables:
#>  $ logins       : chr  "gaborcsardi" "krlmlr" "maelle" "ntamas" ...
#>  $ contributions: int  1504 1012 865 508 281 181 16 9 3 2 ...
#>  $ avatar       : chr  "https://avatars.githubusercontent.com/u/660288?v=4" "https://avatars.githubusercontent.com/u/1741643?v=4" "https://avatars.githubusercontent.com/u/8360597?v=4" "https://avatars.githubusercontent.com/u/195637?v=4" ...
#>  $ type         : chr  "code" "code" "code" "code" ...
str(allcontributors::get_contributors("igraph", "rigraph", check_urls = FALSE))
#> ★  Extracting code contributors
#> ✔ Extracted code contributors
#> ★  Extracting github issue contributors
#> ✔ Extracted github issue contributors
#> 'data.frame':    576 obs. of  4 variables:
#>  $ logins       : chr  "gaborcsardi" "krlmlr" "maelle" "ntamas" ...
#>  $ contributions: int  1504 1012 865 508 281 268 181 109 39 16 ...
#>  $ avatar       : chr  "https://avatars.githubusercontent.com/u/660288?v=4" "https://avatars.githubusercontent.com/u/1741643?v=4" "https://avatars.githubusercontent.com/u/8360597?v=4" "https://avatars.githubusercontent.com/u/195637?v=4" ...
#>  $ type         : chr  "code" "code" "code" "code" ...

Created on 2024-10-11 with reprex v2.1.0

Session info
sessioninfo::session_info()
#> ─ Session info ───────────────────────────────────────────────────────────────
#>  setting  value
#>  version  R version 4.4.1 (2024-06-14)
#>  os       Ubuntu 20.04.6 LTS
#>  system   x86_64, linux-gnu
#>  ui       X11
#>  language en_US.utf8
#>  collate  en_US.utf8
#>  ctype    en_US.utf8
#>  tz       Europe/Paris
#>  date     2024-10-11
#>  pandoc   3.1.11 @ /usr/lib/rstudio/resources/app/bin/quarto/bin/tools/x86_64/ (via rmarkdown)
#> 
#> ─ Packages ───────────────────────────────────────────────────────────────────
#>  package         * version   date (UTC) lib source
#>  allcontributors   0.2.0.006 2024-10-11 [1] Github (ropenscilabs/allcontributors@b4f7be8)
#>  cli               3.6.3     2024-06-21 [1] CRAN (R 4.4.0)
#>  curl              5.2.3     2024-09-20 [1] CRAN (R 4.4.1)
#>  digest            0.6.37    2024-08-19 [1] CRAN (R 4.4.0)
#>  evaluate          1.0.0     2024-09-17 [1] CRAN (R 4.4.1)
#>  fastmap           1.2.0     2024-05-15 [1] CRAN (R 4.4.0)
#>  fs                1.6.4     2024-04-25 [1] CRAN (R 4.4.0)
#>  gh                1.4.1     2024-03-28 [1] CRAN (R 4.4.0)
#>  gitcreds          0.1.2     2022-09-08 [1] CRAN (R 4.4.0)
#>  glue              1.8.0     2024-09-30 [1] CRAN (R 4.4.1)
#>  htmltools         0.5.8.1   2024-04-04 [1] CRAN (R 4.4.0)
#>  httr2             1.0.5     2024-09-26 [1] CRAN (R 4.4.1)
#>  jsonlite          1.8.9     2024-09-20 [1] CRAN (R 4.4.1)
#>  knitr             1.48      2024-07-07 [1] CRAN (R 4.4.0)
#>  lifecycle         1.0.4     2023-11-07 [1] CRAN (R 4.4.0)
#>  magrittr          2.0.3     2022-03-30 [1] CRAN (R 4.4.0)
#>  purrr             1.0.2     2023-08-10 [1] CRAN (R 4.4.0)
#>  R.cache           0.16.0    2022-07-21 [1] CRAN (R 4.4.0)
#>  R.methodsS3       1.8.2     2022-06-13 [1] CRAN (R 4.4.0)
#>  R.oo              1.26.0    2024-01-24 [1] CRAN (R 4.4.0)
#>  R.utils           2.12.3    2023-11-18 [1] CRAN (R 4.4.0)
#>  R6                2.5.1     2021-08-19 [1] CRAN (R 4.4.0)
#>  rappdirs          0.3.3     2021-01-31 [1] CRAN (R 4.4.0)
#>  reprex            2.1.0     2024-01-11 [1] CRAN (R 4.4.0)
#>  rlang             1.1.4     2024-06-04 [1] CRAN (R 4.4.0)
#>  rmarkdown         2.28      2024-08-17 [1] CRAN (R 4.4.0)
#>  rstudioapi        0.16.0    2024-03-24 [1] CRAN (R 4.4.0)
#>  sessioninfo       1.2.2     2021-12-06 [1] CRAN (R 4.4.0)
#>  styler            1.10.3    2024-04-07 [1] CRAN (R 4.4.0)
#>  vctrs             0.6.5     2023-12-01 [1] CRAN (R 4.4.0)
#>  withr             3.0.1     2024-07-31 [1] CRAN (R 4.4.0)
#>  xfun              0.48      2024-10-03 [1] CRAN (R 4.4.1)
#>  yaml              2.3.10    2024-07-26 [1] CRAN (R 4.4.0)
#> 
#>  [1] /home/maelle/R/x86_64-pc-linux-gnu-library/4.4
#>  [2] /usr/local/lib/R/site-library
#>  [3] /usr/lib/R/site-library
#>  [4] /usr/lib/R/library
#> 
#> ──────────────────────────────────────────────────────────────────────────────
@mpadge
Copy link
Member

mpadge commented Oct 11, 2024

Fixing #45 now gives 576 with check_urls = FALSE, and 574 with check_urls = TRUE, with the two removed ones being bots, showing how useful that functionality really is.

@mpadge mpadge closed this as completed Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants