Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

Feature request for adding brakeman to linting #512

Open
henrytseng opened this issue Jul 26, 2019 · 3 comments
Open

Feature request for adding brakeman to linting #512

henrytseng opened this issue Jul 26, 2019 · 3 comments
Assignees
Labels
feature-request Adds currently unsupported functionality

Comments

@henrytseng
Copy link

Your environment

  • vscode-ruby version: 1.36.1 (1.36.1)
  • Ruby version: ruby 2.6.3p62 (2019-04-16 revision 67580) [x86_64-linux-musl]
  • Ruby version manager (if any): rvm
  • VS Code version:
  • Operating System: OSX
  • Using language server? true

Expected behavior

Would love to add Brakeman (https://github.com/presidentbeef/brakeman#configuration-files) to the supported linters. Is that possible? Or would it not be considered a linter? We're using Codeclimate on our project.

Actual behavior

Looks like the current supported linters at this time are:

  • ruby -wc
  • rubocop
  • ruby-lint
  • reek
  • fasterer
  • debride
@wingrunr21
Copy link
Collaborator

That list is actually for the old linter integration. Only rubocop, reek, and standard are being supported on the language server.

That being said, Brakeman seems like a good candidate for support. I'll take a look at what their JSON output looks like. Thanks for the request!

@wingrunr21 wingrunr21 self-assigned this Jul 26, 2019
@wingrunr21 wingrunr21 added the feature-request Adds currently unsupported functionality label Jul 26, 2019
@henrytseng
Copy link
Author

That would be awesome! Thanks.

@jcsrb
Copy link

jcsrb commented Apr 12, 2021

version 5.0.0 - 2021-01-26 of brakeman added Sonarqube report format which might make this integration simpler

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Adds currently unsupported functionality
Projects
None yet
Development

No branches or pull requests

3 participants