Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename group_by into group_by_consecutive #833

Closed
Kinrany opened this issue Jan 2, 2024 · 1 comment
Closed

Rename group_by into group_by_consecutive #833

Kinrany opened this issue Jan 2, 2024 · 1 comment

Comments

@Kinrany
Copy link

Kinrany commented Jan 2, 2024

group_by only groups consecutive elements and may produce multiple groups with the same key. This fact is very easy to miss, it is easily the biggest footgun in the whole library.

I'd like to propose deprecating this method and making it an alias of a new method, group_by_consecutive.

The new name is not at all elegant, I'd love to come up with something better. But that's probably less important than choosing to deprecate the current name.

@Philippe-Cholet
Copy link
Member

We are aware of this, see #374 for the current debate. I know it's an old issue and does not evolve fast enough but it should be resolved eventually there.

So I'm closing this since it's a duplicate.

@Philippe-Cholet Philippe-Cholet closed this as not planned Won't fix, can't repro, duplicate, stale Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants