Skip to content

Commit 2c997ec

Browse files
committed
Auto merge of rust-lang#127367 - ChrisDenton:run-sync, r=<try>
Run alloc sync tests I was browsing the code and this struck me as weird. We're not running some doc tests because, the comment says, Windows builders deadlock. That should absolutely not happen, at least with our current implementation. And if it does happen I'd like to know. Just to be sure though I'll do some try builds. try-job: x86_64-msvc try-job: i686-msvc try-job: i686-mingw try-job: x86_64-mingw
2 parents 11dd90f + 7566f41 commit 2c997ec

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

library/alloc/src/sync.rs

+2-6
Original file line numberDiff line numberDiff line change
@@ -197,11 +197,7 @@ macro_rules! acquire {
197197
///
198198
/// Sharing some immutable data between threads:
199199
///
200-
// Note that we **do not** run these tests here. The windows builders get super
201-
// unhappy if a thread outlives the main thread and then exits at the same time
202-
// (something deadlocks) so we just avoid this entirely by not running these
203-
// tests.
204-
/// ```no_run
200+
/// ```
205201
/// use std::sync::Arc;
206202
/// use std::thread;
207203
///
@@ -220,7 +216,7 @@ macro_rules! acquire {
220216
///
221217
/// [`AtomicUsize`]: core::sync::atomic::AtomicUsize "sync::atomic::AtomicUsize"
222218
///
223-
/// ```no_run
219+
/// ```
224220
/// use std::sync::Arc;
225221
/// use std::sync::atomic::{AtomicUsize, Ordering};
226222
/// use std::thread;

0 commit comments

Comments
 (0)