Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 64be942

Browse files
authoredSep 15, 2024··
Unrolled build for rust-lang#130202
Rollup merge of rust-lang#130202 - onur-ozkan:force-ci-llvm-on-default-profiles, r=Mark-Simulacrum set `download-ci-llvm = true` by default on "library" and "tools" profiles It's very rare for developers to need to modify LLVM, so "if-unchanged" isn't a good default for "tools" and "library" profiles since it fetches the LLVM submodule to track changes.
2 parents 4f1be92 + b5d69ba commit 64be942

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed
 

‎src/bootstrap/defaults/config.library.toml

+2-1
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,5 @@ lto = "off"
1313

1414
[llvm]
1515
# Will download LLVM from CI if available on your platform.
16-
download-ci-llvm = "if-unchanged"
16+
# If you intend to modify `src/llvm-project`, use `"if-unchanged"` or `false` instead.
17+
download-ci-llvm = true

‎src/bootstrap/defaults/config.tools.toml

+2-1
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,5 @@ compiler-docs = true
1717

1818
[llvm]
1919
# Will download LLVM from CI if available on your platform.
20-
download-ci-llvm = "if-unchanged"
20+
# If you intend to modify `src/llvm-project`, use `"if-unchanged"` or `false` instead.
21+
download-ci-llvm = true

‎src/bootstrap/src/utils/change_tracker.rs

+5
Original file line numberDiff line numberDiff line change
@@ -255,4 +255,9 @@ pub const CONFIG_CHANGE_HISTORY: &[ChangeInfo] = &[
255255
severity: ChangeSeverity::Warning,
256256
summary: "`download-ci-llvm = true` now checks if CI llvm is available and has become the default for the compiler profile",
257257
},
258+
ChangeInfo {
259+
change_id: 130202,
260+
severity: ChangeSeverity::Info,
261+
summary: "'tools' and 'library' profiles switched `download-ci-llvm` option from `if-unchanged` to `true`.",
262+
},
258263
];

0 commit comments

Comments
 (0)
Please sign in to comment.