Auto merge of rust-lang#114589 - ijackson:exit-code-default, r=dtolnay

bors · bors · commit d96322459717 · 2023-10-13T14:47:51.000Z
impl Default for ExitCode As suggested here rust-lang#106425 (comment) Needs FCP since this is an insta-stable impl. Ideally we would have `impl From<ExitCode> for ExitStatus` and implement the default `ExitStatus` using that. That is sadly not so easy because of the various strange confusions about `ExitCode` (unix: exit status) vs `ExitStatus` (unix: wait status) in the not-really-unix platforms in `library//src/sys/unix/process`. I'll try to follow that up.
diff --git a/library/std/src/process.rs b/library/std/src/process.rs
@@ -1960,6 +1960,14 @@ impl ExitCode {
     }
 }
 
+/// The default value is [`ExitCode::SUCCESS`]
+#[stable(feature = "process-exitcode-default", since = "CURRENT_RUSTC_VERSION")]
+impl Default for ExitCode {
+    fn default() -> Self {
+        ExitCode::SUCCESS
+    }
+}
+
 #[stable(feature = "process_exitcode", since = "1.61.0")]
 impl From<u8> for ExitCode {
     /// Construct an `ExitCode` from an arbitrary u8 value.

Original file line number	Diff line number	Diff line change
`@@ -1960,6 +1960,14 @@ impl ExitCode {`
`1960`	`1960`	`}`
`1961`	`1961`	`}`
`1962`	`1962`
	`1963`	+/// The default value is [`ExitCode::SUCCESS`]
	`1964`	`+#[stable(feature = "process-exitcode-default", since = "CURRENT_RUSTC_VERSION")]`
	`1965`	`+impl Default for ExitCode {`
	`1966`	`+ fn default() -> Self {`
	`1967`	`+ ExitCode::SUCCESS`
	`1968`	`+ }`
	`1969`	`+}`
	`1970`	`+`
`1963`	`1971`	`#[stable(feature = "process_exitcode", since = "1.61.0")]`
`1964`	`1972`	`impl From<u8> for ExitCode {`
`1965`	`1973`	/// Construct an `ExitCode` from an arbitrary u8 value.