Skip to content

Commit f691ebc

Browse files
authored
Unrolled build for rust-lang#123568
Rollup merge of rust-lang#123568 - Oneirical:delete-tests, r=wesleywiser Clean up tests/ui by removing `does-nothing.rs` In [a previous PR](rust-lang#123297 (comment)), it was suggested that this test be removed: > it's testing a basic diagnostic for an unknown variable (added over a decade ago for rust-lang#154) that is already covered by probably dozens or hundreds of other tests. It was then suggested that [opening a new PR](rust-lang#123563 (comment)) for this would be more organized. I'm setting this as a draft, as: 1. The tests/ui directory is rather disorganized, a large quantity of tests are not even contained inside their own directories. This PR could turn into "clean up the UI tests directory", if I were to place everything into categories (for example, everything related to CLI flags could get placed in a cli directory). 2. This will have a merge conflict with rust-lang#123563 should that get merged. I trust that _this time_, I won't run into [The Incident](rust-lang#123297 (comment)) while rebasing. Edit: Yay, I did it properly!
2 parents 93c131e + cbf1501 commit f691ebc

File tree

3 files changed

+1
-12
lines changed

3 files changed

+1
-12
lines changed

src/tools/tidy/src/ui_tests.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ const ENTRY_LIMIT: usize = 900;
1818
// FIXME: The following limits should be reduced eventually.
1919

2020
const ISSUES_ENTRY_LIMIT: usize = 1722;
21-
const ROOT_ENTRY_LIMIT: usize = 861;
21+
const ROOT_ENTRY_LIMIT: usize = 859;
2222

2323
const EXPECTED_TEST_FILE_EXTENSIONS: &[&str] = &[
2424
"rs", // test source files

tests/ui/does-nothing.rs

-2
This file was deleted.

tests/ui/does-nothing.stderr

-9
This file was deleted.

0 commit comments

Comments
 (0)