Skip to content

Commit f78cc07

Browse files
borsbors
committed
Auto merge of rust-lang#5068 - JohnTitor:split-up-transmute, r=phansch
Split up `transmute` ui test Part of rust-lang#2038 changelog: none
2 parents dd06c06 + c9d5cb9 commit f78cc07

7 files changed

+219
-214
lines changed

‎clippy_dev/src/stderr_length_check.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ use std::io::prelude::*;
77
// The maximum length allowed for stderr files.
88
//
99
// We limit this because small files are easier to deal with than bigger files.
10-
const LIMIT: usize = 275;
10+
const LIMIT: usize = 245;
1111

1212
pub fn check() {
1313
let stderr_files = stderr_files();

‎tests/ui/transmute.rs

-94
Original file line numberDiff line numberDiff line change
@@ -27,46 +27,6 @@ unsafe fn _generic<'a, T, U: 'a>(t: &'a T) {
2727
let _: *const U = core::intrinsics::transmute(t);
2828
}
2929

30-
#[warn(clippy::transmute_ptr_to_ref)]
31-
unsafe fn _ptr_to_ref<T, U>(p: *const T, m: *mut T, o: *const U, om: *mut U) {
32-
let _: &T = std::mem::transmute(p);
33-
let _: &T = &*p;
34-
35-
let _: &mut T = std::mem::transmute(m);
36-
let _: &mut T = &mut *m;
37-
38-
let _: &T = std::mem::transmute(m);
39-
let _: &T = &*m;
40-
41-
let _: &mut T = std::mem::transmute(p as *mut T);
42-
let _ = &mut *(p as *mut T);
43-
44-
let _: &T = std::mem::transmute(o);
45-
let _: &T = &*(o as *const T);
46-
47-
let _: &mut T = std::mem::transmute(om);
48-
let _: &mut T = &mut *(om as *mut T);
49-
50-
let _: &T = std::mem::transmute(om);
51-
let _: &T = &*(om as *const T);
52-
}
53-
54-
#[warn(clippy::transmute_ptr_to_ref)]
55-
fn issue1231() {
56-
struct Foo<'a, T> {
57-
bar: &'a T,
58-
}
59-
60-
let raw = 42 as *const i32;
61-
let _: &Foo<u8> = unsafe { std::mem::transmute::<_, &Foo<_>>(raw) };
62-
63-
let _: &Foo<&u8> = unsafe { std::mem::transmute::<_, &Foo<&_>>(raw) };
64-
65-
type Bar<'a> = &'a u8;
66-
let raw = 42 as *const i32;
67-
unsafe { std::mem::transmute::<_, Bar>(raw) };
68-
}
69-
7030
#[warn(clippy::useless_transmute)]
7131
fn useless() {
7232
unsafe {
@@ -131,58 +91,4 @@ fn bytes_to_str(b: &[u8], mb: &mut [u8]) {
13191
let _: &mut str = unsafe { std::mem::transmute(mb) };
13292
}
13393

134-
// Make sure we can modify lifetimes, which is one of the recommended uses
135-
// of transmute
136-
137-
// Make sure we can do static lifetime transmutes
138-
#[warn(clippy::transmute_ptr_to_ptr)]
139-
unsafe fn transmute_lifetime_to_static<'a, T>(t: &'a T) -> &'static T {
140-
std::mem::transmute::<&'a T, &'static T>(t)
141-
}
142-
143-
// Make sure we can do non-static lifetime transmutes
144-
#[warn(clippy::transmute_ptr_to_ptr)]
145-
unsafe fn transmute_lifetime<'a, 'b, T>(t: &'a T, u: &'b T) -> &'b T {
146-
std::mem::transmute::<&'a T, &'b T>(t)
147-
}
148-
149-
struct LifetimeParam<'a> {
150-
s: &'a str,
151-
}
152-
153-
struct GenericParam<T> {
154-
t: T,
155-
}
156-
157-
#[warn(clippy::transmute_ptr_to_ptr)]
158-
fn transmute_ptr_to_ptr() {
159-
let ptr = &1u32 as *const u32;
160-
let mut_ptr = &mut 1u32 as *mut u32;
161-
unsafe {
162-
// pointer-to-pointer transmutes; bad
163-
let _: *const f32 = std::mem::transmute(ptr);
164-
let _: *mut f32 = std::mem::transmute(mut_ptr);
165-
// ref-ref transmutes; bad
166-
let _: &f32 = std::mem::transmute(&1u32);
167-
let _: &f64 = std::mem::transmute(&1f32);
168-
// ^ this test is here because both f32 and f64 are the same TypeVariant, but they are not
169-
// the same type
170-
let _: &mut f32 = std::mem::transmute(&mut 1u32);
171-
let _: &GenericParam<f32> = std::mem::transmute(&GenericParam { t: 1u32 });
172-
}
173-
174-
// these are recommendations for solving the above; if these lint we need to update
175-
// those suggestions
176-
let _ = ptr as *const f32;
177-
let _ = mut_ptr as *mut f32;
178-
let _ = unsafe { &*(&1u32 as *const u32 as *const f32) };
179-
let _ = unsafe { &mut *(&mut 1u32 as *mut u32 as *mut f32) };
180-
181-
// transmute internal lifetimes, should not lint
182-
let s = "hello world".to_owned();
183-
let lp = LifetimeParam { s: &s };
184-
let _: &LifetimeParam<'static> = unsafe { std::mem::transmute(&lp) };
185-
let _: &GenericParam<&LifetimeParam<'static>> = unsafe { std::mem::transmute(&GenericParam { t: &lp }) };
186-
}
187-
18894
fn main() {}

‎tests/ui/transmute.stderr

+19-119
Original file line numberDiff line numberDiff line change
@@ -24,223 +24,123 @@ error: transmute from a reference to a pointer
2424
LL | let _: *const U = core::intrinsics::transmute(t);
2525
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `t as *const T as *const U`
2626

27-
error: transmute from a pointer type (`*const T`) to a reference type (`&T`)
28-
--> $DIR/transmute.rs:32:17
29-
|
30-
LL | let _: &T = std::mem::transmute(p);
31-
| ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*p`
32-
|
33-
= note: `-D clippy::transmute-ptr-to-ref` implied by `-D warnings`
34-
35-
error: transmute from a pointer type (`*mut T`) to a reference type (`&mut T`)
36-
--> $DIR/transmute.rs:35:21
37-
|
38-
LL | let _: &mut T = std::mem::transmute(m);
39-
| ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *m`
40-
41-
error: transmute from a pointer type (`*mut T`) to a reference type (`&T`)
42-
--> $DIR/transmute.rs:38:17
43-
|
44-
LL | let _: &T = std::mem::transmute(m);
45-
| ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*m`
46-
47-
error: transmute from a pointer type (`*mut T`) to a reference type (`&mut T`)
48-
--> $DIR/transmute.rs:41:21
49-
|
50-
LL | let _: &mut T = std::mem::transmute(p as *mut T);
51-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(p as *mut T)`
52-
53-
error: transmute from a pointer type (`*const U`) to a reference type (`&T`)
54-
--> $DIR/transmute.rs:44:17
55-
|
56-
LL | let _: &T = std::mem::transmute(o);
57-
| ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(o as *const T)`
58-
59-
error: transmute from a pointer type (`*mut U`) to a reference type (`&mut T`)
60-
--> $DIR/transmute.rs:47:21
61-
|
62-
LL | let _: &mut T = std::mem::transmute(om);
63-
| ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(om as *mut T)`
64-
65-
error: transmute from a pointer type (`*mut U`) to a reference type (`&T`)
66-
--> $DIR/transmute.rs:50:17
67-
|
68-
LL | let _: &T = std::mem::transmute(om);
69-
| ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(om as *const T)`
70-
71-
error: transmute from a pointer type (`*const i32`) to a reference type (`&issue1231::Foo<'_, u8>`)
72-
--> $DIR/transmute.rs:61:32
73-
|
74-
LL | let _: &Foo<u8> = unsafe { std::mem::transmute::<_, &Foo<_>>(raw) };
75-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(raw as *const Foo<_>)`
76-
77-
error: transmute from a pointer type (`*const i32`) to a reference type (`&issue1231::Foo<'_, &u8>`)
78-
--> $DIR/transmute.rs:63:33
79-
|
80-
LL | let _: &Foo<&u8> = unsafe { std::mem::transmute::<_, &Foo<&_>>(raw) };
81-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(raw as *const Foo<&_>)`
82-
83-
error: transmute from a pointer type (`*const i32`) to a reference type (`&u8`)
84-
--> $DIR/transmute.rs:67:14
85-
|
86-
LL | unsafe { std::mem::transmute::<_, Bar>(raw) };
87-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(raw as *const u8)`
88-
8927
error: transmute from a type (`std::vec::Vec<i32>`) to itself
90-
--> $DIR/transmute.rs:73:27
28+
--> $DIR/transmute.rs:33:27
9129
|
9230
LL | let _: Vec<i32> = core::intrinsics::transmute(my_vec());
9331
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
9432

9533
error: transmute from a type (`std::vec::Vec<i32>`) to itself
96-
--> $DIR/transmute.rs:75:27
34+
--> $DIR/transmute.rs:35:27
9735
|
9836
LL | let _: Vec<i32> = core::mem::transmute(my_vec());
9937
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
10038

10139
error: transmute from a type (`std::vec::Vec<i32>`) to itself
102-
--> $DIR/transmute.rs:77:27
40+
--> $DIR/transmute.rs:37:27
10341
|
10442
LL | let _: Vec<i32> = std::intrinsics::transmute(my_vec());
10543
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
10644

10745
error: transmute from a type (`std::vec::Vec<i32>`) to itself
108-
--> $DIR/transmute.rs:79:27
46+
--> $DIR/transmute.rs:39:27
10947
|
11048
LL | let _: Vec<i32> = std::mem::transmute(my_vec());
11149
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
11250

11351
error: transmute from a type (`std::vec::Vec<i32>`) to itself
114-
--> $DIR/transmute.rs:81:27
52+
--> $DIR/transmute.rs:41:27
11553
|
11654
LL | let _: Vec<i32> = my_transmute(my_vec());
11755
| ^^^^^^^^^^^^^^^^^^^^^^
11856

11957
error: transmute from an integer to a pointer
120-
--> $DIR/transmute.rs:83:31
58+
--> $DIR/transmute.rs:43:31
12159
|
12260
LL | let _: *const usize = std::mem::transmute(5_isize);
12361
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `5_isize as *const usize`
12462

12563
error: transmute from an integer to a pointer
126-
--> $DIR/transmute.rs:87:31
64+
--> $DIR/transmute.rs:47:31
12765
|
12866
LL | let _: *const usize = std::mem::transmute(1 + 1usize);
12967
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(1 + 1usize) as *const usize`
13068

13169
error: transmute from a type (`*const Usize`) to the type that it points to (`Usize`)
132-
--> $DIR/transmute.rs:102:24
70+
--> $DIR/transmute.rs:62:24
13371
|
13472
LL | let _: Usize = core::intrinsics::transmute(int_const_ptr);
13573
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
13674
|
13775
= note: `-D clippy::crosspointer-transmute` implied by `-D warnings`
13876

13977
error: transmute from a type (`*mut Usize`) to the type that it points to (`Usize`)
140-
--> $DIR/transmute.rs:104:24
78+
--> $DIR/transmute.rs:64:24
14179
|
14280
LL | let _: Usize = core::intrinsics::transmute(int_mut_ptr);
14381
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
14482

14583
error: transmute from a type (`Usize`) to a pointer to that type (`*const Usize`)
146-
--> $DIR/transmute.rs:106:31
84+
--> $DIR/transmute.rs:66:31
14785
|
14886
LL | let _: *const Usize = core::intrinsics::transmute(my_int());
14987
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
15088

15189
error: transmute from a type (`Usize`) to a pointer to that type (`*mut Usize`)
152-
--> $DIR/transmute.rs:108:29
90+
--> $DIR/transmute.rs:68:29
15391
|
15492
LL | let _: *mut Usize = core::intrinsics::transmute(my_int());
15593
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
15694

15795
error: transmute from a `u32` to a `char`
158-
--> $DIR/transmute.rs:114:28
96+
--> $DIR/transmute.rs:74:28
15997
|
16098
LL | let _: char = unsafe { std::mem::transmute(0_u32) };
16199
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::char::from_u32(0_u32).unwrap()`
162100
|
163101
= note: `-D clippy::transmute-int-to-char` implied by `-D warnings`
164102

165103
error: transmute from a `i32` to a `char`
166-
--> $DIR/transmute.rs:115:28
104+
--> $DIR/transmute.rs:75:28
167105
|
168106
LL | let _: char = unsafe { std::mem::transmute(0_i32) };
169107
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::char::from_u32(0_i32 as u32).unwrap()`
170108

171109
error: transmute from a `u8` to a `bool`
172-
--> $DIR/transmute.rs:120:28
110+
--> $DIR/transmute.rs:80:28
173111
|
174112
LL | let _: bool = unsafe { std::mem::transmute(0_u8) };
175113
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `0_u8 != 0`
176114
|
177115
= note: `-D clippy::transmute-int-to-bool` implied by `-D warnings`
178116

179117
error: transmute from a `u32` to a `f32`
180-
--> $DIR/transmute.rs:125:27
118+
--> $DIR/transmute.rs:85:27
181119
|
182120
LL | let _: f32 = unsafe { std::mem::transmute(0_u32) };
183121
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(0_u32)`
184122
|
185123
= note: `-D clippy::transmute-int-to-float` implied by `-D warnings`
186124

187125
error: transmute from a `i32` to a `f32`
188-
--> $DIR/transmute.rs:126:27
126+
--> $DIR/transmute.rs:86:27
189127
|
190128
LL | let _: f32 = unsafe { std::mem::transmute(0_i32) };
191129
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(0_i32 as u32)`
192130

193131
error: transmute from a `&[u8]` to a `&str`
194-
--> $DIR/transmute.rs:130:28
132+
--> $DIR/transmute.rs:90:28
195133
|
196134
LL | let _: &str = unsafe { std::mem::transmute(b) };
197135
| ^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::str::from_utf8(b).unwrap()`
198136
|
199137
= note: `-D clippy::transmute-bytes-to-str` implied by `-D warnings`
200138

201139
error: transmute from a `&mut [u8]` to a `&mut str`
202-
--> $DIR/transmute.rs:131:32
140+
--> $DIR/transmute.rs:91:32
203141
|
204142
LL | let _: &mut str = unsafe { std::mem::transmute(mb) };
205143
| ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::str::from_utf8_mut(mb).unwrap()`
206144

207-
error: transmute from a pointer to a pointer
208-
--> $DIR/transmute.rs:163:29
209-
|
210-
LL | let _: *const f32 = std::mem::transmute(ptr);
211-
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr as *const f32`
212-
|
213-
= note: `-D clippy::transmute-ptr-to-ptr` implied by `-D warnings`
214-
215-
error: transmute from a pointer to a pointer
216-
--> $DIR/transmute.rs:164:27
217-
|
218-
LL | let _: *mut f32 = std::mem::transmute(mut_ptr);
219-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `mut_ptr as *mut f32`
220-
221-
error: transmute from a reference to a reference
222-
--> $DIR/transmute.rs:166:23
223-
|
224-
LL | let _: &f32 = std::mem::transmute(&1u32);
225-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&1u32 as *const u32 as *const f32)`
226-
227-
error: transmute from a reference to a reference
228-
--> $DIR/transmute.rs:167:23
229-
|
230-
LL | let _: &f64 = std::mem::transmute(&1f32);
231-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&1f32 as *const f32 as *const f64)`
232-
233-
error: transmute from a reference to a reference
234-
--> $DIR/transmute.rs:170:27
235-
|
236-
LL | let _: &mut f32 = std::mem::transmute(&mut 1u32);
237-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut *(&mut 1u32 as *mut u32 as *mut f32)`
238-
239-
error: transmute from a reference to a reference
240-
--> $DIR/transmute.rs:171:37
241-
|
242-
LL | let _: &GenericParam<f32> = std::mem::transmute(&GenericParam { t: 1u32 });
243-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&GenericParam { t: 1u32 } as *const GenericParam<u32> as *const GenericParam<f32>)`
244-
245-
error: aborting due to 38 previous errors
145+
error: aborting due to 22 previous errors
246146

0 commit comments

Comments
 (0)