chore(ci): Catch naive use of AtomicU64 early

epage · epage · commit 93cd5ef84639 · 2023-11-16T11:58:58.000-06:00
AtomicU64 is not portable and use of it, without `target_has_atomic`, will fail CI for rust-lang/rust when the cargo submodule gets updated (see #12981). If there is a reason to use it, we could always `allow` in that one case.
diff --git a/clippy.toml b/clippy.toml
@@ -6,3 +6,6 @@ disallowed-methods = [
     { path = "std::env::vars", reason = "not recommended to use in Cargo. See rust-lang/cargo#11588" },
     { path = "std::env::vars_os", reason = "not recommended to use in Cargo. See rust-lang/cargo#11588" },
 ]
+disallowed-types = [
+    "std::sync::atomic::AtomicU64",
+]

Original file line number	Diff line number	Diff line change
`@@ -6,3 +6,6 @@ disallowed-methods = [`
`6`	`6`	`{ path = "std::env::vars", reason = "not recommended to use in Cargo. See rust-lang/cargo#11588" },`
`7`	`7`	`{ path = "std::env::vars_os", reason = "not recommended to use in Cargo. See rust-lang/cargo#11588" },`
`8`	`8`	`]`
	`9`	`+disallowed-types = [`
	`10`	`+ "std::sync::atomic::AtomicU64",`
	`11`	`+]`