Auto merge of #12928 - hi-rustin:rustin-patch-feature-name, r=epage

Do not allow empty feature name

Author: bors

Diff for: src/cargo/core/summary.rs

@@ -431,6 +431,9 @@ impl fmt::Display for FeatureValue {
 pub type FeatureMap = BTreeMap<InternedString, Vec<FeatureValue>>;
 
 fn validate_feature_name(pkg_id: PackageId, name: &str) -> CargoResult<()> {
+    if name.is_empty() {
+        bail!("feature name cannot be empty");
+    }
     let mut chars = name.chars();
     if let Some(ch) = chars.next() {
         if !(unicode_xid::UnicodeXID::is_xid_start(ch) || ch == '_' || ch.is_digit(10)) {
@@ -488,5 +491,6 @@ mod tests {
         assert!(validate_feature_name(pkg_id, "?foo").is_err());
         assert!(validate_feature_name(pkg_id, "ⒶⒷⒸ").is_err());
         assert!(validate_feature_name(pkg_id, "a¼").is_err());
+        assert!(validate_feature_name(pkg_id, "").is_err());
     }
 }

Diff for: tests/testsuite/features.rs

@@ -35,6 +35,37 @@ Caused by:
         .run();
 }
 
+#[cargo_test]
+fn empty_feature_name() {
+    let p = project()
+        .file(
+            "Cargo.toml",
+            r#"
+                [package]
+                name = "foo"
+                version = "0.0.1"
+                authors = []
+
+                [features]
+                "" = []
+            "#,
+        )
+        .file("src/main.rs", "")
+        .build();
+
+    p.cargo("check")
+        .with_status(101)
+        .with_stderr(
+            "\
+[ERROR] failed to parse manifest at `[..]`
+
+Caused by:
+  feature name cannot be empty
+",
+        )
+        .run();
+}
+
 #[cargo_test]
 fn same_name() {
     // Feature with the same name as a dependency.