Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo check fails to detect an error #5747

Closed
graylikeme opened this issue Jul 18, 2018 · 3 comments
Closed

Cargo check fails to detect an error #5747

graylikeme opened this issue Jul 18, 2018 · 3 comments

Comments

@graylikeme
Copy link

When running cargo check it fails to output an error that is detected with cargo build
b_reg is u8 and running stable 1.27.1

error: attempt to shift right with overflow
  --> src\cpu\instructions.rs:39:36
   |
39 |             cpu.flags.half_carry = ((b_reg | 0x0F) - 1) >> 31 > 0;
   |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: #[deny(exceeding_bitshifts)] on by default
@alexcrichton
Copy link
Member

Thanks for the report! I think you actually had it right the first time around with rust-lang/rust#52484 in that this is an issue with rust-lang/rust rather than Cargo (which is just delegating to rustc). Want to re-move the issue back over there?

@graylikeme
Copy link
Author

Oh really. Then i'll do just that

@graylikeme
Copy link
Author

Issue moved to rust-lang/rust#52484

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants