Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -Z small-data-threshold #689

Closed
3 tasks done
paulmenage opened this issue Nov 17, 2023 · 3 comments
Closed
3 tasks done

Add -Z small-data-threshold #689

paulmenage opened this issue Nov 17, 2023 · 3 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@paulmenage
Copy link

paulmenage commented Nov 17, 2023

Proposal

On some targets (including MIPS, M68K, RISC-V, Hexagon) and configurations, LLVM will place small static data objects in the .sdata and .sbss sections, intended to allow size optimizations in embedded systems that can access data in these sections via small offsets from a register. LLVM provides command line arguments and/or IR module flags to control/disable this behavior in the event that it's unwanted, but they're different on every target.

This proposal is to add the -Z small-data-threshold flag, which appropriately configures LLVM's small-data threshold for the target in use.

See rust-lang/rust#117465 for a possible implementation of the proposed change.

Mentors or Reviewers

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

@paulmenage paulmenage added major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team labels Nov 17, 2023
@rustbot
Copy link
Collaborator

rustbot commented Nov 17, 2023

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Nov 17, 2023
@nikic
Copy link
Contributor

nikic commented Nov 20, 2023

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Nov 20, 2023
@apiraino
Copy link
Contributor

apiraino commented Dec 7, 2023

@rustbot label -final-comment-period +major-change-accepted

@apiraino apiraino closed this as completed Dec 7, 2023
@rustbot rustbot added major-change-accepted A major change proposal that was accepted and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Dec 7, 2023
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Development

No branches or pull requests

4 participants