Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proc_macro_span feature used on "stable" builds #1564

Closed
Nemo157 opened this issue Apr 27, 2019 · 4 comments · Fixed by #1597
Closed

proc_macro_span feature used on "stable" builds #1564

Nemo157 opened this issue Apr 27, 2019 · 4 comments · Fixed by #1597
Assignees

Comments

@Nemo157
Copy link
Member

Nemo157 commented Apr 27, 2019

With the changes from #1555 we are now attempting to build with something equivalent to what will be the 1.36 compiler. Unfortunately rust-lang/rust#60289 has revealed that proc-macro2 is using an unstable feature when it's built on nightly, which has broken those CI builds.

I've opened dtolnay/proc-macro2#175 to see if we can get a way to disable that feature in proc-macro2, but if we can't do that soon I'll probably revert the Travis changes from #1555 until it happens.

@Nemo157 Nemo157 self-assigned this Apr 27, 2019
@taiki-e
Copy link
Member

taiki-e commented Apr 27, 2019

I think we can use RUSTFLAGS="-Z allow-features=proc_macro_span" temporarily.

@Nemo157
Copy link
Member Author

Nemo157 commented Apr 27, 2019

@taiki-e great idea, I’ll open a PR in a bit.

@Nemo157
Copy link
Member Author

Nemo157 commented Apr 27, 2019

#1565 added that workaround, leaving this open till we hear back about proc-macro2 changing so we can hopefully remove that.

@Nemo157 Nemo157 changed the title CI failing on "stable" compiler proc_macro_span feature used on "stable" builds Apr 27, 2019
@taiki-e
Copy link
Member

taiki-e commented May 7, 2019

(We probably can remove proc_macro_span from allow-features because dtolnay/proc-macro2#176 merged and proc-macro2 4.29 released.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants