Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename curly-quotes config option to smart-punctuation #1936

Closed
virtualritz opened this issue Nov 24, 2022 · 2 comments · Fixed by #2327
Closed

Rename curly-quotes config option to smart-punctuation #1936

virtualritz opened this issue Nov 24, 2022 · 2 comments · Fixed by #2327

Comments

@virtualritz
Copy link

virtualritz commented Nov 24, 2022

See here. What pulldown-cmark does is replace quotes but also dashes and ellipses.

Basically this turns something like:

"He took the boat Paris---Rome ... When he arrived he exclamated -- instantly -- 'Heureka!'."

Into:

“He took the boat Paris—Rome … When he arrived he exclamated – instantly – ‘Heureka, I found a secret waterway!’.”

@mgeisler
Copy link
Contributor

mgeisler commented Jan 9, 2023

Hi @virtualritz,

You might already know this, but for completeness: the curly-quotes option does the last part. However, it doesn't localize the quotes based on the language and it doesn't handle dashes either.

@virtualritz virtualritz changed the title Smartypants aka automatic microtypography support? Rename curly-quotes config option to smart-punctuation Jan 2, 2024
@virtualritz
Copy link
Author

virtualritz commented Jan 2, 2024

I updated this ticket. The feature is actually fully there as of lately but wrongly named now.

And w/o support for foreign quotes -- I opened a ticket in pulldown-cmark for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants