Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styling of inline code item has same styling as inline code item w/ hyperlink #261

Closed
frewsxcv opened this issue Apr 30, 2017 · 2 comments
Closed

Styling of inline code item has same styling as inline code item w/ hyperlink #261

frewsxcv opened this issue Apr 30, 2017 · 2 comments
Labels
A-Style Area: Style (CSS, etc.) C-papercut Category: A small usability bug E-Easy Experience: Easy

Comments

@frewsxcv
Copy link
Member

mdbook styles these identically:

`foo`

[`foo`](https://foo.com)

which isn't great if you want the user to know that the second item is a link. Here's how github styles them:

foo

foo
@azerupi azerupi added A-Style Area: Style (CSS, etc.) E-Easy Experience: Easy C-papercut Category: A small usability bug and removed CSS labels May 15, 2017
This was referenced May 19, 2017
Merged
Closed
@budziq
Copy link
Contributor

budziq commented May 20, 2017

Should it not be closed due to https://github.com/azerupi/mdBook/issues/289?

@azerupi
Copy link
Contributor

azerupi commented May 20, 2017

Yes, it should :)

@azerupi azerupi closed this as completed May 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Style Area: Style (CSS, etc.) C-papercut Category: A small usability bug E-Easy Experience: Easy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@budziq @frewsxcv @azerupi