We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
true
false
At present, true and false are each defined twice in the Lexer blocks: once as keywords and once as part of BOOLEAN_LITERAL.
Lexer
I think we should do one of:
change the BOOLEAN_LITERAL definition to use KW_TRUE | KW_FALSE rather than true | false
remove BOOLEAN_LITERAL and update literal-expr.md and patterns.md accordingly
The second is a larger change but seems more in the spirit of #939. It would also make the text
Any kind of literal (string, integer, etc) with any suffix is valid as a token, and can be passed to a macro without producing an error
in tokens.md no longer appear to make a claim about suffixes following true and false.
The text was updated successfully, but these errors were encountered:
I was asked if I had an opinion on this. I do not; the nitty gritty grammar decisions aren't something I've spent much brainpower thinking about.
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
At present,
true
andfalse
are each defined twice in theLexer
blocks: once as keywords and once as part of BOOLEAN_LITERAL.I think we should do one of:
change the BOOLEAN_LITERAL definition to use KW_TRUE | KW_FALSE rather than
true
|false
remove BOOLEAN_LITERAL and update literal-expr.md and patterns.md accordingly
The second is a larger change but seems more in the spirit of #939. It would also make the text
in tokens.md no longer appear to make a claim about suffixes following
true
andfalse
.The text was updated successfully, but these errors were encountered: