let-else: use DropTemps to fix borrowck complaints

This prevents *any* unreachable_code warnings on
DropTemps, including from its other uses.

Author: cormacrelf

compiler/rustc_ast_lowering/src/block.rs

@@ -159,6 +159,7 @@ impl<'a, 'hir> LoweringContext<'a, 'hir> {
             span,
             kind: hir::ExprKind::If(let_expr, then_expr, Some(else_expr)),
         });
+        let drop_temps = self.expr_drop_temps(span, if_expr, AttrVec::new());
         if !self.sess.features_untracked().let_else {
             feature_err(
                 &self.sess.parse_sess,
@@ -168,6 +169,6 @@ impl<'a, 'hir> LoweringContext<'a, 'hir> {
             )
             .emit();
         }
-        if_expr
+        drop_temps
     }
 }

compiler/rustc_typeck/src/check/expr.rs

@@ -225,6 +225,7 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
             | ExprKind::If(..)
             | ExprKind::Let(..)
             | ExprKind::Loop(..)
+            | ExprKind::DropTemps(..)
             | ExprKind::Match(..) => {}
             // If `expr` is a result of desugaring the try block and is an ok-wrapped
             // diverging expression (e.g. it arose from desugaring of `try { return }`),