Skip to content

Commit 204f19b

Browse files
committed
rewrite no-alloc-shim to rmake
1 parent 89f5f22 commit 204f19b

File tree

4 files changed

+57
-27
lines changed

4 files changed

+57
-27
lines changed

src/tools/tidy/src/allowed_run_make_makefiles.txt

-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ run-make/libtest-junit/Makefile
1414
run-make/libtest-thread-limit/Makefile
1515
run-make/macos-deployment-target/Makefile
1616
run-make/native-link-modifier-bundle/Makefile
17-
run-make/no-alloc-shim/Makefile
1817
run-make/remap-path-prefix-dwarf/Makefile
1918
run-make/reproducible-build/Makefile
2019
run-make/rlib-format-packed-bundled-libs/Makefile

tests/run-make/min-global-align/rmake.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
// This tests ensure that global variables respect the target minimum alignment.
1+
// This test checks that global variables respect the target minimum alignment.
22
// The three bools `STATIC_BOOL`, `STATIC_MUT_BOOL`, and `CONST_BOOL` all have
33
// type-alignment of 1, but some targets require greater global alignment.
44
// See https://github.com/rust-lang/rust/pull/44440
55

66
//@ only-linux
7-
// Reason: this test is target-independent, considering compilation is targeted
7+
// Reason: this test is specific to linux, considering compilation is targeted
88
// towards linux architectures only.
99

1010
use run_make_support::{assert_count_is, llvm_components_contain, rfs, rustc};

tests/run-make/no-alloc-shim/Makefile

-24
This file was deleted.

tests/run-make/no-alloc-shim/rmake.rs

+55
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
1+
// This test checks the compatibility of the interaction between `--emit obj` and
2+
// `#[global_allocator]`, as it is now possible to invoke the latter without the
3+
// allocator shim since #86844. As this feature is unstable, it should fail if
4+
// --cfg check_feature_gate is passed.
5+
// See https://github.com/rust-lang/rust/pull/86844
6+
7+
//@ ignore-cross-compile
8+
// Reason: the compiled binary is executed
9+
10+
//@ ignore-msvc
11+
//FIXME(Oneirical): Getting this to work on MSVC requires passing libcmt.lib to CC,
12+
// which is not trivial to do.
13+
// Tracking issue: https://github.com/rust-lang/rust/issues/128602
14+
// Discussion: https://github.com/rust-lang/rust/pull/128407#discussion_r1702439172
15+
16+
use run_make_support::{cc, cwd, has_extension, has_prefix, run, rustc, shallow_find_files};
17+
18+
fn main() {
19+
rustc().input("foo.rs").crate_type("bin").emit("obj").panic("abort").run();
20+
let libdir = rustc().print("target-libdir").run().stdout_utf8();
21+
let libdir = libdir.trim();
22+
23+
let alloc_libs = shallow_find_files(&libdir, |path| {
24+
has_prefix(path, "liballoc-") && has_extension(path, "rlib")
25+
});
26+
let core_libs = shallow_find_files(&libdir, |path| {
27+
has_prefix(path, "libcore-") && has_extension(path, "rlib")
28+
});
29+
let compiler_builtins_libs = shallow_find_files(libdir, |path| {
30+
has_prefix(path, "libcompiler_builtins") && has_extension(path, "rlib")
31+
});
32+
33+
cc().input("foo.o")
34+
.out_exe("foo")
35+
.args(&alloc_libs)
36+
.args(&core_libs)
37+
.args(&compiler_builtins_libs)
38+
.run();
39+
run("foo");
40+
41+
// Check that linking without __rust_no_alloc_shim_is_unstable defined fails
42+
rustc()
43+
.input("foo.rs")
44+
.crate_type("bin")
45+
.emit("obj")
46+
.panic("abort")
47+
.cfg("check_feature_gate")
48+
.run();
49+
cc().input("foo.o")
50+
.out_exe("foo")
51+
.args(&alloc_libs)
52+
.args(&core_libs)
53+
.args(&compiler_builtins_libs)
54+
.run_fail();
55+
}

0 commit comments

Comments
 (0)