Skip to content

Commit 32f01b2

Browse files
committed
don't warn about a missing change-id in CI
fixes 130352
1 parent 02b1be1 commit 32f01b2

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

src/bootstrap/src/bin/main.rs

+7-3
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ use bootstrap::{
1414
find_recent_config_change_ids, human_readable_changes, t, Build, Config, Flags, Subcommand,
1515
CONFIG_CHANGE_HISTORY,
1616
};
17+
use build_helper::ci::CiEnv;
1718

1819
fn main() {
1920
let args = env::args().skip(1).collect::<Vec<_>>();
@@ -54,9 +55,12 @@ fn main() {
5455
};
5556
}
5657

57-
// check_version warnings are not printed during setup
58-
let changelog_suggestion =
59-
if matches!(config.cmd, Subcommand::Setup { .. }) { None } else { check_version(&config) };
58+
// check_version warnings are not printed during setup, or during CI
59+
let changelog_suggestion = if matches!(config.cmd, Subcommand::Setup { .. }) || CiEnv::is_ci() {
60+
None
61+
} else {
62+
check_version(&config)
63+
};
6064

6165
// NOTE: Since `./configure` generates a `config.toml`, distro maintainers will see the
6266
// changelog warning, not the `x.py setup` message.

0 commit comments

Comments
 (0)