Skip to content

Commit 4008cf1

Browse files
authored
Rollup merge of #62906 - cuviper:debuginfo-level, r=Mark-Simulacrum
Require a value for configure --debuginfo-level In `configure.py`, using the `o` function creates an enable/disable boolean setting, and writes `true` or `false` in `config.toml`. However, rustbuild is expecting to parse a `u32` debuginfo level. We can change to the `v` function to have the options require a value.
2 parents 06ee158 + 1aeadcc commit 4008cf1

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/bootstrap/configure.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -76,11 +76,11 @@ def v(*args):
7676
o("llvm-assertions", "llvm.assertions", "build LLVM with assertions")
7777
o("debug-assertions", "rust.debug-assertions", "build with debugging assertions")
7878
o("llvm-release-debuginfo", "llvm.release-debuginfo", "build LLVM with debugger metadata")
79-
o("debuginfo-level", "rust.debuginfo-level", "debuginfo level for Rust code")
80-
o("debuginfo-level-rustc", "rust.debuginfo-level-rustc", "debuginfo level for the compiler")
81-
o("debuginfo-level-std", "rust.debuginfo-level-std", "debuginfo level for the standard library")
82-
o("debuginfo-level-tools", "rust.debuginfo-level-tools", "debuginfo level for the tools")
83-
o("debuginfo-level-tests", "rust.debuginfo-level-tests", "debuginfo level for the test suites run with compiletest")
79+
v("debuginfo-level", "rust.debuginfo-level", "debuginfo level for Rust code")
80+
v("debuginfo-level-rustc", "rust.debuginfo-level-rustc", "debuginfo level for the compiler")
81+
v("debuginfo-level-std", "rust.debuginfo-level-std", "debuginfo level for the standard library")
82+
v("debuginfo-level-tools", "rust.debuginfo-level-tools", "debuginfo level for the tools")
83+
v("debuginfo-level-tests", "rust.debuginfo-level-tests", "debuginfo level for the test suites run with compiletest")
8484
v("save-toolstates", "rust.save-toolstates", "save build and test status of external tools into this file")
8585

8686
v("prefix", "install.prefix", "set installation prefix")

src/ci/run.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ if [ "$DEPLOY$DEPLOY_ALT" = "1" ]; then
5050
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --release-channel=$RUST_RELEASE_CHANNEL"
5151
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --enable-llvm-static-stdcpp"
5252
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set rust.remap-debuginfo"
53-
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set rust.debuginfo-level-std=1"
53+
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --debuginfo-level-std=1"
5454

5555
if [ "$NO_LLVM_ASSERTIONS" = "1" ]; then
5656
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --disable-llvm-assertions"

0 commit comments

Comments
 (0)