Skip to content

Commit 45507e4

Browse files
Rollup merge of #125566 - camelid:notify-accepted, r=GuillaumeGomez
Notify T-rustdoc for beta-accepted and stable-accepted too Otherwise, it's unclear when the nomination label is removed whether the backport was accepted, thus nomination removed, or if the backport was rejected, thus nomination removed. r? ````@GuillaumeGomez````
2 parents 25b079a + 91b3ef5 commit 45507e4

File tree

1 file changed

+26
-0
lines changed

1 file changed

+26
-0
lines changed

triagebot.toml

+26
Original file line numberDiff line numberDiff line change
@@ -468,6 +468,19 @@ message_on_remove = "PR #{number}'s beta-nomination has been removed."
468468
message_on_close = "PR #{number} has been closed. Thanks for participating!"
469469
message_on_reopen = "PR #{number} has been reopened. Pinging @*T-rustdoc*."
470470

471+
# FIXME: Patch triagebot to support `notify-zulip.<label>` getting mapped to an array of actions.
472+
# At the moment, the beta-accepted+T-rustdoc action fully occupies the beta-accepted slot
473+
# preventing others from adding more beta-accepted actions.
474+
[notify-zulip."beta-accepted"]
475+
required_labels = ["T-rustdoc"]
476+
zulip_stream = 266220 # #t-rustdoc
477+
# Put it in the same thread as beta-nominated.
478+
topic = "beta-nominated: #{number}"
479+
message_on_add = "PR #{number} has been **accepted** for beta backport."
480+
message_on_remove = "PR #{number}'s beta-acceptance has been **removed**."
481+
message_on_close = "PR #{number} has been closed. Thanks for participating!"
482+
message_on_reopen = "PR #{number} has been reopened. Pinging @*T-rustdoc*."
483+
471484
# FIXME: Patch triagebot to support `notify-zulip.<label>` getting mapped to an array of actions.
472485
# At the moment, the stable-nominated+T-rustdoc action fully occupies the stable-nominated slot
473486
# preventing others from adding more stable-nominated actions.
@@ -492,6 +505,19 @@ message_on_remove = "PR #{number}'s stable-nomination has been removed."
492505
message_on_close = "PR #{number} has been closed. Thanks for participating!"
493506
message_on_reopen = "PR #{number} has been reopened. Pinging @*T-rustdoc*."
494507

508+
# FIXME: Patch triagebot to support `notify-zulip.<label>` getting mapped to an array of actions.
509+
# At the moment, the stable-accepted+T-rustdoc action fully occupies the stable-accepted slot
510+
# preventing others from adding more stable-accepted actions.
511+
[notify-zulip."stable-accepted"]
512+
required_labels = ["T-rustdoc"]
513+
zulip_stream = 266220 # #t-rustdoc
514+
# Put it in the same thread as stable-nominated.
515+
topic = "stable-nominated: #{number}"
516+
message_on_add = "PR #{number} has been **accepted** for stable backport."
517+
message_on_remove = "PR #{number}'s stable-acceptance has been **removed**."
518+
message_on_close = "PR #{number} has been closed. Thanks for participating!"
519+
message_on_reopen = "PR #{number} has been reopened. Pinging @*T-rustdoc*."
520+
495521
[notify-zulip."I-types-nominated"]
496522
zulip_stream = 326866 # #T-types/nominated
497523
topic = "#{number}: {title}"

0 commit comments

Comments
 (0)