Skip to content

Commit 474e091

Browse files
committedJan 13, 2022
Move FIXME to if statement
1 parent aafcbf1 commit 474e091

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed
 

‎src/librustdoc/json/mod.rs

+4-4
Original file line numberDiff line numberDiff line change
@@ -171,10 +171,6 @@ impl<'tcx> FormatRenderer<'tcx> for JsonRenderer<'tcx> {
171171
/// the hashmap because certain items (traits and types) need to have their mappings for trait
172172
/// implementations filled out before they're inserted.
173173
fn item(&mut self, item: clean::Item) -> Result<(), Error> {
174-
// FIXME(CraftSpider): We skip children of local blanket implementations, as we'll have
175-
// already seen the actual generic impl, and the generated ones don't need documenting.
176-
// This is necessary due to the visibility, return type, and self arg of the generated
177-
// impls not quite matching, and will no longer be necessary when the mismatch is fixed.
178174
let local_blanket_impl = match item.def_id {
179175
clean::ItemId::Blanket { impl_id, .. } => impl_id.is_local(),
180176
clean::ItemId::Auto { .. }
@@ -183,6 +179,10 @@ impl<'tcx> FormatRenderer<'tcx> for JsonRenderer<'tcx> {
183179
};
184180

185181
// Flatten items that recursively store other items
182+
// FIXME(CraftSpider): We skip children of local blanket implementations, as we'll have
183+
// already seen the actual generic impl, and the generated ones don't need documenting.
184+
// This is necessary due to the visibility, return type, and self arg of the generated
185+
// impls not quite matching, and will no longer be necessary when the mismatch is fixed.
186186
if !local_blanket_impl {
187187
item.kind.inner_items().for_each(|i| self.item(i.clone()).unwrap());
188188
}

0 commit comments

Comments
 (0)
Please sign in to comment.