Skip to content

Commit 5d60720

Browse files
committed
remove ALL traces PathBuf's as_mut_vec
1 parent 564cfc6 commit 5d60720

File tree

5 files changed

+7
-24
lines changed

5 files changed

+7
-24
lines changed

library/std/src/ffi/os_str.rs

+2-8
Original file line numberDiff line numberDiff line change
@@ -552,23 +552,17 @@ impl OsString {
552552
OsStr::from_inner_mut(self.inner.leak())
553553
}
554554

555-
/// Part of a hack to make PathBuf::push/pop more efficient.
556-
//#[inline]
557-
//pub(crate) fn as_mut_vec_for_path_buf(&mut self) -> &mut Vec<u8> {
558-
// self.inner.as_mut_vec_for_path_buf()
559-
//}
560-
555+
/// Provides plumbing to core `Vec::truncate`.
561556
/// More well behaving alternative to allowing outer types
562557
/// full mutable access to the core `Vec`.
563-
/// Provides plumbing to core `Vec::truncate`.
564558
#[inline]
565559
pub(crate) fn truncate(&mut self, len: usize) {
566560
self.inner.truncate(len);
567561
}
568562

563+
/// Provides plumbing to core `Vec::extend_from_slice`.
569564
/// More well behaving alternative to allowing outer types
570565
/// full mutable access to the core `Vec`.
571-
/// Provides plumbing to core `Vec::extend_from_slice`.
572566
#[inline]
573567
pub(crate) fn extend_from_slice(&mut self, other: &[u8]) {
574568
self.inner.extend_from_slice(other);

library/std/src/path.rs

-5
Original file line numberDiff line numberDiff line change
@@ -1163,11 +1163,6 @@ pub struct PathBuf {
11631163
}
11641164

11651165
impl PathBuf {
1166-
//#[inline]
1167-
//fn as_mut_vec(&mut self) -> &mut Vec<u8> {
1168-
// self.inner.as_mut_vec_for_path_buf()
1169-
//}
1170-
11711166
/// Allocates an empty `PathBuf`.
11721167
///
11731168
/// # Examples

library/std/src/sys/os_str/bytes.rs

+2-8
Original file line numberDiff line numberDiff line change
@@ -202,23 +202,17 @@ impl Buf {
202202
self.as_slice().into_rc()
203203
}
204204

205-
/// Part of a hack to make PathBuf::push/pop more efficient.
206-
//#[inline]
207-
//pub(crate) fn as_mut_vec_for_path_buf(&mut self) -> &mut Vec<u8> {
208-
// &mut self.inner
209-
//}
210-
205+
/// Provides plumbing to core `Vec::truncate`.
211206
/// More well behaving alternative to allowing outer types
212207
/// full mutable access to the core `Vec`.
213-
/// Provides plumbing to core `Vec::truncate`.
214208
#[inline]
215209
pub(crate) fn truncate(&mut self, len: usize) {
216210
self.inner.truncate(len);
217211
}
218212

213+
/// Provides plumbing to core `Vec::extend_from_slice`.
219214
/// More well behaving alternative to allowing outer types
220215
/// full mutable access to the core `Vec`.
221-
/// Provides plumbing to core `Vec::extend_from_slice`.
222216
#[inline]
223217
pub(crate) fn extend_from_slice(&mut self, other: &[u8]) {
224218
self.inner.extend_from_slice(other);

library/std/src/sys/os_str/wtf8.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -165,17 +165,17 @@ impl Buf {
165165
self.as_slice().into_rc()
166166
}
167167

168+
/// Provides plumbing to core `Vec::truncate`.
168169
/// More well behaving alternative to allowing outer types
169170
/// full mutable access to the core `Vec`.
170-
/// Provides plumbing to core `Vec::truncate`.
171171
#[inline]
172172
pub(crate) fn truncate(&mut self, len: usize) {
173173
self.inner.truncate(len);
174174
}
175175

176+
/// Provides plumbing to core `Vec::extend_from_slice`.
176177
/// More well behaving alternative to allowing outer types
177178
/// full mutable access to the core `Vec`.
178-
/// Provides plumbing to core `Vec::extend_from_slice`.
179179
#[inline]
180180
pub(crate) fn extend_from_slice(&mut self, other: &[u8]) {
181181
self.inner.extend_from_slice(other);

library/std/src/sys_common/wtf8.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -474,9 +474,9 @@ impl Wtf8Buf {
474474
Wtf8Buf { bytes: bytes.into_vec(), is_known_utf8: false }
475475
}
476476

477+
/// Provides plumbing to core `Vec::extend_from_slice`.
477478
/// More well behaving alternative to allowing outer types
478479
/// full mutable access to the core `Vec`.
479-
/// Provides plumbing to core `Vec::extend_from_slice`.
480480
#[inline]
481481
pub(crate) fn extend_from_slice(&mut self, other: &[u8]) {
482482
self.bytes.extend_from_slice(other);

0 commit comments

Comments
 (0)