Skip to content

Commit 6d03bbd

Browse files
committed
constify mem::discriminant
1 parent f943349 commit 6d03bbd

File tree

6 files changed

+32
-1
lines changed

6 files changed

+32
-1
lines changed

src/libcore/intrinsics.rs

+1
Original file line numberDiff line numberDiff line change
@@ -1852,6 +1852,7 @@ extern "rust-intrinsic" {
18521852
///
18531853
/// The stabilized version of this intrinsic is
18541854
/// [`std::mem::discriminant`](../../std/mem/fn.discriminant.html)
1855+
#[rustc_const_unstable(feature = "const_discriminant", issue = "69821")]
18551856
pub fn discriminant_value<T>(v: &T) -> u64;
18561857

18571858
/// Rust's "try catch" construct which invokes the function pointer `f` with

src/libcore/lib.rs

+1
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@
7272
#![feature(concat_idents)]
7373
#![feature(const_ascii_ctype_on_intrinsics)]
7474
#![feature(const_alloc_layout)]
75+
#![feature(const_discriminant)]
7576
#![feature(const_if_match)]
7677
#![feature(const_loop)]
7778
#![feature(const_checked_int_methods)]

src/libcore/mem/mod.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -864,6 +864,7 @@ impl<T> fmt::Debug for Discriminant<T> {
864864
/// assert_ne!(mem::discriminant(&Foo::B(3)), mem::discriminant(&Foo::C(3)));
865865
/// ```
866866
#[stable(feature = "discriminant_value", since = "1.21.0")]
867-
pub fn discriminant<T>(v: &T) -> Discriminant<T> {
867+
#[rustc_const_unstable(feature = "const_discriminant", issue = "69821")]
868+
pub const fn discriminant<T>(v: &T) -> Discriminant<T> {
868869
Discriminant(intrinsics::discriminant_value(v), PhantomData)
869870
}

src/librustc_mir/interpret/intrinsics.rs

+5
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,11 @@ impl<'mir, 'tcx, M: Machine<'mir, 'tcx>> InterpCx<'mir, 'tcx, M> {
216216
};
217217
self.write_scalar(val, dest)?;
218218
}
219+
sym::discriminant_value => {
220+
let place = self.deref_operand(args[0])?;
221+
let discr_val = self.read_discriminant(place.into())?.0;
222+
self.write_scalar(Scalar::from_uint(discr_val, dest.layout.size), dest)?;
223+
}
219224
sym::unchecked_shl
220225
| sym::unchecked_shr
221226
| sym::unchecked_add

src/librustc_span/symbol.rs

+1
Original file line numberDiff line numberDiff line change
@@ -265,6 +265,7 @@ symbols! {
265265
derive,
266266
diagnostic,
267267
direct,
268+
discriminant_value,
268269
doc,
269270
doc_alias,
270271
doc_cfg,
+22
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
// run-pass
2+
#![feature(const_discriminant)]
3+
4+
use std::mem::{discriminant, Discriminant};
5+
6+
enum Test {
7+
A(u8),
8+
B,
9+
C { a: u8, b: u8 },
10+
}
11+
12+
const TEST_A: Discriminant<Test> = discriminant(&Test::A(5));
13+
const TEST_A_OTHER: Discriminant<Test> = discriminant(&Test::A(17));
14+
const TEST_B: Discriminant<Test> = discriminant(&Test::B);
15+
16+
fn main() {
17+
assert_eq!(TEST_A, TEST_A_OTHER);
18+
assert_eq!(TEST_A, discriminant(&Test::A(17)));
19+
assert_eq!(TEST_B, discriminant(&Test::B));
20+
assert_ne!(TEST_A, TEST_B);
21+
assert_ne!(TEST_B, discriminant(&Test::C { a: 42, b: 7 }));
22+
}

0 commit comments

Comments
 (0)