Skip to content

Commit 834d761

Browse files
authored
Rollup merge of #78570 - sasurau4:test/check-pass-print-type-size, r=jyn514
Remove FIXME comment in print_type_sizes ui test suite ## Overview Helps with #62277 > The type sizes are likely only printed when the actual layout is computed. For generic types, this only happens during codegen. ref: https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Codegen.20process.20question/near/215836807 Some tests like `multiple_types.rs` are passed even if using `check-pass`. But tests should be agnostic to when the actual layout is computed. The `build-pass` is intentionally used for them. I remove FIXME comments.
2 parents 1c66688 + 5c8d25f commit 834d761

12 files changed

+12
-12
lines changed

src/test/ui/print_type_sizes/anonymous.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// compile-flags: -Z print-type-sizes
2-
// build-pass (FIXME(62277): could be check-pass?)
2+
// build-pass
33

44
// All of the types that occur in this function are uninteresting, in
55
// that one cannot control the sizes of these types with the same sort

src/test/ui/print_type_sizes/generics.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// compile-flags: -Z print-type-sizes
2-
// build-pass (FIXME(62277): could be check-pass?)
2+
// build-pass
33
// ignore-pass
44
// ^-- needed because `--pass check` does not emit the output needed.
55
// FIXME: consider using an attribute instead of side-effects.

src/test/ui/print_type_sizes/multiple_types.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// compile-flags: -Z print-type-sizes
2-
// build-pass (FIXME(62277): could be check-pass?)
2+
// build-pass
33

44
// This file illustrates that when multiple structural types occur in
55
// a function, every one of them is included in the output.

src/test/ui/print_type_sizes/niche-filling.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// compile-flags: -Z print-type-sizes
2-
// build-pass (FIXME(62277): could be check-pass?)
2+
// build-pass
33
// ignore-pass
44
// ^-- needed because `--pass check` does not emit the output needed.
55
// FIXME: consider using an attribute instead of side-effects.

src/test/ui/print_type_sizes/no_duplicates.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// compile-flags: -Z print-type-sizes
2-
// build-pass (FIXME(62277): could be check-pass?)
2+
// build-pass
33
// ignore-pass
44
// ^-- needed because `--pass check` does not emit the output needed.
55
// FIXME: consider using an attribute instead of side-effects.

src/test/ui/print_type_sizes/packed.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// compile-flags: -Z print-type-sizes
2-
// build-pass (FIXME(62277): could be check-pass?)
2+
// build-pass
33
// ignore-pass
44
// ^-- needed because `--pass check` does not emit the output needed.
55
// FIXME: consider using an attribute instead of side-effects.

src/test/ui/print_type_sizes/padding.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// compile-flags: -Z print-type-sizes
2-
// build-pass (FIXME(62277): could be check-pass?)
2+
// build-pass
33

44
// This file illustrates how padding is handled: alignment
55
// requirements can lead to the introduction of padding, either before

src/test/ui/print_type_sizes/repr-align.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// compile-flags: -Z print-type-sizes
2-
// build-pass (FIXME(62277): could be check-pass?)
2+
// build-pass
33
// ignore-pass
44
// ^-- needed because `--pass check` does not emit the output needed.
55
// FIXME: consider using an attribute instead of side-effects.

src/test/ui/print_type_sizes/repr_int_c.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// compile-flags: -Z print-type-sizes
2-
// build-pass (FIXME(62277): could be check-pass?)
2+
// build-pass
33

44
// This test makes sure that the tag is not grown for `repr(C)` or `repr(u8)`
55
// variants (see https://github.com/rust-lang/rust/issues/50098 for the original bug).

src/test/ui/print_type_sizes/uninhabited.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// compile-flags: -Z print-type-sizes
2-
// build-pass (FIXME(62277): could be check-pass?)
2+
// build-pass
33
// ignore-pass
44
// ^-- needed because `--pass check` does not emit the output needed.
55
// FIXME: consider using an attribute instead of side-effects.

src/test/ui/print_type_sizes/variants.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// compile-flags: -Z print-type-sizes
2-
// build-pass (FIXME(62277): could be check-pass?)
2+
// build-pass
33

44
// This file illustrates two things:
55
//

src/test/ui/print_type_sizes/zero-sized-fields.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// compile-flags: -Z print-type-sizes
2-
// build-pass (FIXME(62277): could be check-pass?)
2+
// build-pass
33
// ignore-pass
44

55
// At one point, zero-sized fields such as those in this file were causing

0 commit comments

Comments
 (0)