Improve help popup detection

GuillaumeGomez · GuillaumeGomez · commit 863796be7deb · 2019-10-25T13:43:25.000+02:00
diff --git a/src/librustdoc/html/static/main.js b/src/librustdoc/html/static/main.js
@@ -379,10 +379,11 @@ function getSearchElement() {
 
                 set_fragment(cur_id);
             }
-        } else if (hasClass(document.getElementById("help"), "hidden") === false) {
-            var is_inside_help_popup = document.getElementById("help").contains(ev.target);
+        } else if (hasClass(getHelpElement(), "hidden") === false) {
+            var help = getHelpElement();
+            var is_inside_help_popup = ev.target !== help && help.contains(ev.target);
             if (is_inside_help_popup === false) {
-                addClass(document.getElementById("help"), "hidden");
+                addClass(help, "hidden");
                 removeClass(document.body, "blur");
             }
         } else {

Original file line number	Diff line number	Diff line change
`@@ -379,10 +379,11 @@ function getSearchElement() {`
`379`	`379`
`380`	`380`	`set_fragment(cur_id);`
`381`	`381`	`}`
`382`		`- } else if (hasClass(document.getElementById("help"), "hidden") === false) {`
`383`		`- var is_inside_help_popup = document.getElementById("help").contains(ev.target);`
	`382`	`+ } else if (hasClass(getHelpElement(), "hidden") === false) {`
	`383`	`+ var help = getHelpElement();`
	`384`	`+ var is_inside_help_popup = ev.target !== help && help.contains(ev.target);`
`384`	`385`	`if (is_inside_help_popup === false) {`
`385`		`- addClass(document.getElementById("help"), "hidden");`
	`386`	`+ addClass(help, "hidden");`
`386`	`387`	`removeClass(document.body, "blur");`
`387`	`388`	`}`
`388`	`389`	`} else {`